Re: [PATCH 1/6] powerpc: Use lwarx hint in spinlocks

2010-02-17 Thread Nick Piggin
On Wed, Feb 17, 2010 at 08:37:14PM +1100, Anton Blanchard wrote: > > Hi Nick, > > > Cool. How does it go when there are significant amount of instructions > > between the lock and the unlock? A real(ish) workload, like dbench on > > ramdisk (which should hit the dcache lock). > > Good question,

Re: [PATCH 1/6] powerpc: Use lwarx hint in spinlocks

2010-02-17 Thread Anton Blanchard
Hi Nick, > Cool. How does it go when there are significant amount of instructions > between the lock and the unlock? A real(ish) workload, like dbench on > ramdisk (which should hit the dcache lock). Good question, I'll see if we can see a difference on dbench. Anton __

Re: [PATCH 1/6] powerpc: Use lwarx hint in spinlocks

2010-02-15 Thread Olof Johansson
On Wed, Feb 10, 2010 at 09:57:28PM +1100, Anton Blanchard wrote: > v2: We do this only for 64bit until we can verify all 32bit CPUs. > > Tested so far: 970 (thanks Ben), POWER5, POWER6, POWER7 > Still to test: RS64, POWER3, POWER4 Tested on PA6T as well, no performance impact (as expected). -O

Re: [PATCH 1/6] powerpc: Use lwarx hint in spinlocks

2010-02-10 Thread Nick Piggin
On Wed, Feb 10, 2010 at 09:57:28PM +1100, Anton Blanchard wrote: > > Recent versions of the PowerPC architecture added a hint bit to the larx > instructions to differentiate between an atomic operation and a lock > operation: > > > 0 Other programs might attempt to modify the word in storage add

[PATCH 1/6] powerpc: Use lwarx hint in spinlocks

2010-02-10 Thread Anton Blanchard
Recent versions of the PowerPC architecture added a hint bit to the larx instructions to differentiate between an atomic operation and a lock operation: > 0 Other programs might attempt to modify the word in storage addressed by EA > even if the subsequent Store Conditional succeeds. > > 1 Other