Re: [PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program

2021-06-17 Thread Segher Boessenkool
On Thu, Jun 17, 2021 at 11:40:23AM +1000, Nicholas Piggin wrote: > Excerpts from Segher Boessenkool's message of June 17, 2021 9:37 am: > > On Tue, Jun 15, 2021 at 09:05:27AM +1000, Paul Mackerras wrote: > >> This ensures that we don't get a decrementer interrupt arriving before > >> we have set

Re: [PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program

2021-06-16 Thread Michael Ellerman
Nicholas Piggin writes: > Excerpts from Segher Boessenkool's message of June 17, 2021 9:37 am: >> On Tue, Jun 15, 2021 at 09:05:27AM +1000, Paul Mackerras wrote: >>> This ensures that we don't get a decrementer interrupt arriving before >>> we have set up a handler for it. >> >> Maybe add a

Re: [PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program

2021-06-16 Thread Nicholas Piggin
Excerpts from Segher Boessenkool's message of June 17, 2021 9:37 am: > On Tue, Jun 15, 2021 at 09:05:27AM +1000, Paul Mackerras wrote: >> This ensures that we don't get a decrementer interrupt arriving before >> we have set up a handler for it. > > Maybe add a comment saying this is setting

Re: [PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program

2021-06-16 Thread Segher Boessenkool
On Tue, Jun 15, 2021 at 09:05:27AM +1000, Paul Mackerras wrote: > This ensures that we don't get a decrementer interrupt arriving before > we have set up a handler for it. Maybe add a comment saying this is setting MSR[EE]=0 for that? Or do other bits here matter as well? Segher

Re: [PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program

2021-06-14 Thread Nicholas Piggin
Excerpts from Paul Mackerras's message of June 15, 2021 9:05 am: > This ensures that we don't get a decrementer interrupt arriving before > we have set up a handler for it. Would this be better off merged in the previous patch (maybe with comment)? Why don't other platform_init()s seem to

[PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program

2021-06-14 Thread Paul Mackerras
This ensures that we don't get a decrementer interrupt arriving before we have set up a handler for it. Signed-off-by: Paul Mackerras --- arch/powerpc/boot/microwatt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/microwatt.c b/arch/powerpc/boot/microwatt.c index