[PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers

2007-11-14 Thread Valentine Barshak
This patch makes PowerPC 4xx UIC use generic edge and level irq handlers instead of a custom handle_uic_irq() function. Acking a level irq on UIC has no effect if the interrupt is still asserted by the device, even if the interrupt is already masked. So, to really de-assert the interrupt we need

Re: [PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers

2007-11-14 Thread Valentine Barshak
Benjamin Herrenschmidt wrote: On Wed, 2007-11-14 at 13:13 +1100, David Gibson wrote: Hrm. I *think* I'm convinced this is safe, although acking in a callback which doesn't say it acks is rather yucky. Essentially this code is trading flow readability (because just reading handle_level_irq

Re: [PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers

2007-11-13 Thread David Gibson
On Tue, Nov 13, 2007 at 11:27:31PM +0300, Valentine Barshak wrote: This patch makes PowerPC 4xx UIC use generic edge and level irq handlers instead of a custom handle_uic_irq() function. Acking a level irq on UIC has no effect if the interrupt is still asserted by the device, even if the

Re: [PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers

2007-11-13 Thread Benjamin Herrenschmidt
On Wed, 2007-11-14 at 13:13 +1100, David Gibson wrote: Hrm. I *think* I'm convinced this is safe, although acking in a callback which doesn't say it acks is rather yucky. Essentially this code is trading flow readability (because just reading handle_level_irq will tell you something other