Re: [PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-22 Thread Julia Lawall
On Mon, 22 Aug 2011, walter harms wrote: Am 21.08.2011 18:10, schrieb Julia Lawall: From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match

Re: [PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-22 Thread walter harms
Am 21.08.2011 18:10, schrieb Julia Lawall: From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match that finds this problem is as follows:

Re: [PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-22 Thread Julia Lawall
On Mon, 22 Aug 2011, walter harms wrote: Am 21.08.2011 18:10, schrieb Julia Lawall: From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match

[PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-21 Thread Julia Lawall
From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e,e1,e2; @@