Re: [PATCH 2/2] clk: ppc-corenet: don't use platform_driver to init the clock device

2014-10-18 Thread Kevin Hao
On Fri, Oct 17, 2014 at 07:58:55AM +0200, Scott Wood wrote: > On Fri, 2014-10-17 at 06:55 +0800, Kevin Hao wrote: > > I have thought about to put it in a more common place such as time_init(), > > but this will be in conflict with mpc512x board. How about add an > > arch_initcall(mpc85xx_clk_init)

Re: [PATCH 2/2] clk: ppc-corenet: don't use platform_driver to init the clock device

2014-10-16 Thread Scott Wood
On Fri, 2014-10-17 at 06:55 +0800, Kevin Hao wrote: > On Thu, Oct 16, 2014 at 11:55:23PM +0200, Scott Wood wrote: > > On Thu, 2014-10-16 at 19:18 +0800, Kevin Hao wrote: > > > diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c > > > b/arch/powerpc/platforms/85xx/corenet_generic.c > > > ind

Re: [PATCH 2/2] clk: ppc-corenet: don't use platform_driver to init the clock device

2014-10-16 Thread Kevin Hao
On Thu, Oct 16, 2014 at 11:55:23PM +0200, Scott Wood wrote: > On Thu, 2014-10-16 at 19:18 +0800, Kevin Hao wrote: > > diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c > > b/arch/powerpc/platforms/85xx/corenet_generic.c > > index e56b89a792ed..7677cfecb787 100644 > > --- a/arch/powerpc/pl

Re: [PATCH 2/2] clk: ppc-corenet: don't use platform_driver to init the clock device

2014-10-16 Thread Scott Wood
On Thu, 2014-10-16 at 19:18 +0800, Kevin Hao wrote: > In commit da788acb2838 ("clk: ppc-corenet: Fix Section mismatch > warning"), we put the ppc_corenet_clk_driver struct to init section > in order to fix section mismatch warning. This is definitely wrong > because the kernel would free the memori

[PATCH 2/2] clk: ppc-corenet: don't use platform_driver to init the clock device

2014-10-16 Thread Kevin Hao
In commit da788acb2838 ("clk: ppc-corenet: Fix Section mismatch warning"), we put the ppc_corenet_clk_driver struct to init section in order to fix section mismatch warning. This is definitely wrong because the kernel would free the memories occupied by ppc_corenet_clk_driver after boot while this