Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Denis Kirjanov
On 12/14/15, Michael Ellerman wrote: > On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote: >> On Tue, 08 Dec 2015 08:02:15 +1100 >> Benjamin Herrenschmidt wrote: >> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: >> > > > +

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Michael Ellerman
On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote: > On Tue, 08 Dec 2015 08:02:15 +1100 > Benjamin Herrenschmidt wrote: > > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: > > > > + TP_CONDITION(cpu_online(smp_processor_id())), > > > > + > > > >

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-07 Thread Steven Rostedt
I can take this series through my tree, but I need a acked-by from a PPC maintainer for this patch. -- Steve On Tue, 24 Nov 2015 21:23:39 +0300 Denis Kirjanov wrote: > ./drmgr -c cpu -a -r gives the following warning: > > [ 2327.035563] > RCU used illegally from

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-07 Thread Benjamin Herrenschmidt
On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: > > + TP_CONDITION(cpu_online(smp_processor_id())), > > + This should probably be some kind of __raw version though, hcalls can be called in contexts where the debug stuff in smp_processor_id() isn't safe (or preempt enabled). Cheers,

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-07 Thread Steven Rostedt
On Tue, 08 Dec 2015 08:02:15 +1100 Benjamin Herrenschmidt wrote: > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: > > > + TP_CONDITION(cpu_online(smp_processor_id())), > > > + > > This should probably be some kind of __raw version though, hcalls can >

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-26 Thread Denis Kirjanov
On 11/26/15, Michael Ellerman wrote: > On Thu, 2015-11-26 at 11:15 +0300, Denis Kirjanov wrote: >> On 11/26/15, Michael Ellerman wrote: >> > On Tue, 2015-11-24 at 21:23 +0300, Denis Kirjanov wrote: >> > I can't get this to hit. >> > >> > I've got

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-26 Thread Denis Kirjanov
On 11/26/15, Michael Ellerman wrote: > On Tue, 2015-11-24 at 21:23 +0300, Denis Kirjanov wrote: > >> ./drmgr -c cpu -a -r gives the following warning: >> >> [ 2327.035563] RCU used illegally from offline CPU! >> rcu_scheduler_active = 1, debug_locks = 1 >> [ 2327.035564] no

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-26 Thread Michael Ellerman
On Thu, 2015-11-26 at 11:15 +0300, Denis Kirjanov wrote: > On 11/26/15, Michael Ellerman wrote: > > On Tue, 2015-11-24 at 21:23 +0300, Denis Kirjanov wrote: > > I can't get this to hit. > > > > I've got LOCKDEP=y, I've enabled the hcall tracepoints, and then I offline > > a

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-25 Thread Michael Ellerman
On Tue, 2015-11-24 at 21:23 +0300, Denis Kirjanov wrote: > ./drmgr -c cpu -a -r gives the following warning: > > [ 2327.035563] RCU used illegally from offline CPU! > rcu_scheduler_active = 1, debug_locks = 1 > [ 2327.035564] no locks held by swapper/12/0. > [ 2327.035565] stack backtrace: > [

[PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-24 Thread Denis Kirjanov
./drmgr -c cpu -a -r gives the following warning: [ 2327.035563] RCU used illegally from offline CPU! rcu_scheduler_active = 1, debug_locks = 1 [ 2327.035564] no locks held by swapper/12/0. [ 2327.035565] stack backtrace: [ 2327.035567] CPU: 12 PID: 0 Comm: swapper/12 Tainted: G S