Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-31 Thread Srikar Dronamraju
* Peter Zijlstra [2018-08-31 13:26:39]: > On Fri, Aug 31, 2018 at 01:12:53PM +0200, Peter Zijlstra wrote: > > NAK, not until you've fixed every cpu_to_node() user in the kernel to > > deal with that mask changing. > > Also, what happens if userspace reads that information; uses libnuma and >

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 04:53:50AM -0700, Srikar Dronamraju wrote: > The topology events are suppose to be very rare. > From whatever small experiments I have done till now, unless tasks are > bound to both cpu and memory, they seem to be coping well with topology > updates. IOW, if you're not

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 04:53:50AM -0700, Srikar Dronamraju wrote: > * Peter Zijlstra [2018-08-31 13:26:39]: > > > On Fri, Aug 31, 2018 at 01:12:53PM +0200, Peter Zijlstra wrote: > > > NAK, not until you've fixed every cpu_to_node() user in the kernel to > > > deal with that mask changing. > >

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 01:12:53PM +0200, Peter Zijlstra wrote: > NAK, not until you've fixed every cpu_to_node() user in the kernel to > deal with that mask changing. Also, what happens if userspace reads that information; uses libnuma and then you go and shift the world underneath their feet?

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 03:27:24AM -0700, Srikar Dronamraju wrote: > * Peter Zijlstra [2018-08-29 10:02:19]: > Powerpc lpars running on Phyp have 2 modes. Dedicated and shared. > > Dedicated lpars are similar to kvm guest with vcpupin. Like i know what that means... I'm not big on virt. I

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-31 Thread Srikar Dronamraju
* Peter Zijlstra [2018-08-29 10:02:19]: > On Fri, Aug 10, 2018 at 10:30:19PM +0530, Srikar Dronamraju wrote: > > With commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node > > sched domain") scheduler introduces an new numa level. However on shared > > lpars like powerpc, this extra

Re: [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-29 Thread Peter Zijlstra
On Fri, Aug 10, 2018 at 10:30:19PM +0530, Srikar Dronamraju wrote: > With commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node > sched domain") scheduler introduces an new numa level. However on shared > lpars like powerpc, this extra sched domain creation can lead to > repeated rcu

[PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch

2018-08-10 Thread Srikar Dronamraju
With commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node sched domain") scheduler introduces an new numa level. However on shared lpars like powerpc, this extra sched domain creation can lead to repeated rcu stalls, sometimes even causing unresponsive systems on boot. On such