Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-28 Thread Arnd Bergmann
On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Module parameter names should be short, so just minmax would be a good name, but better put the module_param() line right after that. If it's a bool type, I would just leave out the initialization. Ok. But leaving

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-28 Thread Kevin Diggs
Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: I think the module_exit() function should leave the frequency in a well-defined state, so the easiest way to get there is probably to delete the timer, and then manually set the frequency. I really

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Kevin Diggs
Arnd Bergmann wrote: On Tuesday 26 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: On Monday 25 August 2008, Kevin Diggs wrote: Most people list their email address here as well For reasons I'd rather not go into, my email address is not likely to remain valid for much longer.

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Arnd Bergmann
On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Ok, thanks for the explanation. I now saw that you also use '_v' for variables (I guess). These should probably go the same way. Actually the _v means global variable. I would prefer to keep it. The reasoning on

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Geert Uytterhoeven
On Wed, 27 Aug 2008, Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Are there even SMP boards based on a 750? I thought only 74xx and 603/604 were SMP capable. Not that I have heard of. I thought it was lacking some hardware that was

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Brad Boyer
On Wed, Aug 27, 2008 at 01:40:10PM +0200, Geert Uytterhoeven wrote: On Wed, 27 Aug 2008, Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Are there even SMP boards based on a 750? I thought only 74xx and 603/604 were SMP capable. Not

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Geert Uytterhoeven
On Wed, 27 Aug 2008, Brad Boyer wrote: On Wed, Aug 27, 2008 at 01:40:10PM +0200, Geert Uytterhoeven wrote: On Wed, 27 Aug 2008, Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Are there even SMP boards based on a 750? I thought only 74xx

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Kevin Diggs
Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Ok, thanks for the explanation. I now saw that you also use '_v' for variables (I guess). These should probably go the same way. Actually the _v means global variable. I would prefer to keep it.

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Kevin Diggs
Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Ok, thanks for the explanation. I now saw that you also use '_v' for variables (I guess). These should probably go the same way. Actually the _v means global variable. I would prefer to keep it.

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: On Monday 25 August 2008, Kevin Diggs wrote: Most people list their email address here as well For reasons I'd rather not go into, my email address is not likely to remain valid for much longer. Maybe you should get a

[PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-25 Thread Kevin Diggs
This adds the actual cpufreq driver for the 750GX. It supports all integer ratios that are valid for the processor model and bus frequency. It has two modes of operation. Normal mode uses all valid frequencies. In minmaxmode, only the minimum and maximum are used. This provides the ability for

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-25 Thread Arnd Bergmann
On Monday 25 August 2008, Kevin Diggs wrote: + * cf750gx.c - cpufreq driver for the dual PLLs in the 750gx Thanks for posting this driver and for your attention for detail and for documentation in particular. Few people bother to write documentation at this level. I don't understand enough of

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-25 Thread Kevin Diggs
Arnd Bergmann wrote: On Monday 25 August 2008, Kevin Diggs wrote: + * cf750gx.c - cpufreq driver for the dual PLLs in the 750gx Thanks for posting this driver and for your attention for detail and for documentation in particular. Few people bother to write documentation at this level. I