Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-06-29 Thread David Brownell
On Tuesday 17 June 2008, Grant Likely wrote: > >>> This patch splits the allocation and registration portions of code out > >>> of spi_new_device() and creates three new functions; spi_alloc_device(), > >>> spi_register_device(), and spi_device_release(). > >> > >> I have no problem with the first

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-06-29 Thread David Brownell
On Friday 23 May 2008, Grant Likely wrote: > Question:  spi_alloc_device() (and the original code) does a > spi_master_get() on the spi_master device.  Doesn't spi_master_put() > need to be called when the device is discarded?  spi_dev_put() doesn't > do that explicitly; is it an implicit operation

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-06-17 Thread Grant Likely
On Sat, May 24, 2008 at 12:43 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > On Wed, May 21, 2008 at 6:17 PM, David Brownell <[EMAIL PROTECTED]> wrote: >> On Friday 16 May 2008, Grant Likely wrote: >>> >>> This patch splits the allocation and registration portions of code out >>> of spi_new_device()

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-05-23 Thread Grant Likely
On Sat, May 24, 2008 at 12:43 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > On Wed, May 21, 2008 at 6:17 PM, David Brownell <[EMAIL PROTECTED]> wrote: >> On Friday 16 May 2008, Grant Likely wrote: >>> >>> This patch splits the allocation and registration portions of code out >>> of spi_new_device()

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-05-23 Thread Grant Likely
On Wed, May 21, 2008 at 6:17 PM, David Brownell <[EMAIL PROTECTED]> wrote: > On Friday 16 May 2008, Grant Likely wrote: >> >> This patch splits the allocation and registration portions of code out >> of spi_new_device() and creates three new functions; spi_alloc_device(), >> spi_register_device(),

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-05-21 Thread David Brownell
On Friday 16 May 2008, Grant Likely wrote: > > This patch splits the allocation and registration portions of code out > of spi_new_device() and creates three new functions; spi_alloc_device(), > spi_register_device(), and spi_device_release(). I have no problem with the first two, but why the la

[PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

2008-05-16 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> spi_new_device() allocates and registers an spi device all in one swoop. If the driver needs to add extra data to the spi_device before it is registered, then this causes problems. This patch splits the allocation and registration portions of code out of spi