Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-03-07 Thread David Miller
From: Alistair Popple Date: Thu, 6 Mar 2014 14:52:25 +1100 > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN > + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); When an expression spans multiple lines, the lines should end with operators rather than begin with them. Also, it wou

[PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-03-05 Thread Alistair Popple
The IBM PPC476GTR SoC that is used on the Akebono board uses a different ethernet PHY interface that has wake on lan (WOL) support with the IBM emac. This patch adds support to the IBM emac driver for this new PHY interface. At this stage the wake on lan functionality has not been implemented. Si