Mostly looks good, a few comments below.
On Fri, Jun 20, 2008 at 10:58:35AM -0600, John Rigby wrote:
Implements the api defined in include/clk.h
Current only getting frequencies is supported
not setting.
Need a more detailed commit message. This doesn't tell me much.
Signed-off-by:
Implements the api defined in include/clk.h
Current only getting frequencies is supported
not setting.
Signed-off-by: John Rigby [EMAIL PROTECTED]
---
arch/powerpc/platforms/512x/Makefile |1 +
arch/powerpc/platforms/512x/clock.c | 729 ++
2 files changed,
Hi John,
On Fri, 20 Jun 2008 10:58:35 -0600 John Rigby [EMAIL PROTECTED] wrote:
+struct module;
Since you include linux/module.h, you don't need this.
+static unsigned long devtree_getfreq(char *nodetype, char *clockname)
+{
+ struct device_node *node;
+ const unsigned int *fp;
+
