Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-02 Thread Scott Wood
On 12/02/2011 10:34 AM, Paul Gortmaker wrote: > On 11-12-02 06:30 AM, Alan Cox wrote: OK, I'll simply change the above to CONFIG_PPC then. >>> >>> It does, the bug is in the uart IP which I don't think we ever plan on >>> fixing, so 32 or 64-bit parts will have it for ever and ever ;) >> >> I

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-02 Thread Paul Gortmaker
On 11-12-02 06:30 AM, Alan Cox wrote: >>> OK, I'll simply change the above to CONFIG_PPC then. >> >> It does, the bug is in the uart IP which I don't think we ever plan on >> fixing, so 32 or 64-bit parts will have it for ever and ever ;) > > It should be runtime selected, there should be no ifde

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-02 Thread Alan Cox
> > OK, I'll simply change the above to CONFIG_PPC then. > > It does, the bug is in the uart IP which I don't think we ever plan on > fixing, so 32 or 64-bit parts will have it for ever and ever ;) It should be runtime selected, there should be no ifdefs here. __

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-01 Thread Paul Gortmaker
On Thu, Dec 1, 2011 at 7:57 PM, Alan Cox wrote: > >> @@ -1553,7 +1554,15 @@ static void serial8250_handle_port(struct >> uart_8250_port *up) >>       spin_lock_irqsave(&up->port.lock, flags); >> >> -     status = serial_inp(up, UART_LSR); >> +     /* Workaround for IRQ storm errata on break with F

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-01 Thread Alan Cox
> @@ -1553,7 +1554,15 @@ static void serial8250_handle_port(struct > uart_8250_port *up) > spin_lock_irqsave(&up->port.lock, flags); > > - status = serial_inp(up, UART_LSR); > + /* Workaround for IRQ storm errata on break with Freescale > 16550 */ > + if (UART_BUG_FSLBK & up->

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-01 Thread Kumar Gala
On Dec 1, 2011, at 6:05 PM, Paul Gortmaker wrote: > On 11-12-01 06:51 PM, Scott Wood wrote: >> On 12/01/2011 05:47 PM, Paul Gortmaker wrote: >>> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h >>> index 8c660af..b0f4042 100644 >>> --- a/include/linux/serial_8250.h >>> +++ b

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-01 Thread Paul Gortmaker
On 11-12-01 06:51 PM, Scott Wood wrote: > On 12/01/2011 05:47 PM, Paul Gortmaker wrote: >> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h >> index 8c660af..b0f4042 100644 >> --- a/include/linux/serial_8250.h >> +++ b/include/linux/serial_8250.h >> @@ -18,6 +18,11 @@ >> #def

Re: [PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-01 Thread Scott Wood
On 12/01/2011 05:47 PM, Paul Gortmaker wrote: > diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h > index 8c660af..b0f4042 100644 > --- a/include/linux/serial_8250.h > +++ b/include/linux/serial_8250.h > @@ -18,6 +18,11 @@ > #define UART_BUG_TXEN(1 << 1)/* bugg

[PATCH 3/3] 8250: add workaround for MPC8[356]xx UART break IRQ storm

2011-12-01 Thread Paul Gortmaker
Sending a break on the SOC UARTs found in some MPC83xx/85xx/86xx chips seems to cause a short lived IRQ storm (/proc/interrupts typically shows somewhere between 300 and 1500 events). Unfortunately this renders SysRQ over the serial console completely inoperable. The suggested workaround in the e