Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-24 Thread Sergei Shtylyov
Hello. Anton Vorontsov wrote: This controller does not integrate the root hub, so this driver also fakes one-port hub. External hub is required to support more than one device. ... Please, no. What exactly 'no'? ;-) No one-port hubs I guess

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-24 Thread Sergei Shtylyov
Hello, I wrote: This controller does not integrate the root hub, so this driver also fakes one-port hub. External hub is required to support more than one device. ... Please, no. What exactly 'no'? ;-) No one-port hubs I guess -- they are

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-24 Thread David Brownell
On Wednesday 24 September 2008, Sergei Shtylyov wrote:   ... then the root hub emulation is completely pointless.     It isn't. We always should emulate the root hub. The root hub is part and parcel of any USB Host. Even the one-port one.    Hm, maybe that's what USB core thinks

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-24 Thread Sergei Shtylyov
Hello. David Brownell wrote: ... then the root hub emulation is completely pointless. It isn't. We always should emulate the root hub. The root hub is part and parcel of any USB Host. Even the one-port one. Hm, maybe that's what USB core thinks (because UHCI/OHCI/EHCI all have it) but

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-23 Thread Anton Vorontsov
On Fri, Sep 19, 2008 at 04:23:24PM -0700, Andrew Morton wrote: On Thu, 18 Sep 2008 19:17:46 +0400 Anton Vorontsov [EMAIL PROTECTED] wrote: This patch adds support for the FHCI USB controller, as found in the Freescale MPC836x and MPC832x processors. It can support Full or Low speed

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-23 Thread Sergei Shtylyov
Hello. Anton Vorontsov wrote: This patch adds support for the FHCI USB controller, as found in the Freescale MPC836x and MPC832x processors. It can support Full or Low speed modes. Quite a lot the hardware is doing by itself (SOF generation, CRC generation and checking), though scheduling and

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-23 Thread Sergei Shtylyov
Hello, I wrote: This patch adds support for the FHCI USB controller, as found in the Freescale MPC836x and MPC832x processors. It can support Full or Low speed modes. Ah, it's not even high-speed? Quite a lot the hardware is doing by itself (SOF generation, CRC generation and checking),

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-23 Thread Anton Vorontsov
On Wed, Sep 24, 2008 at 01:35:41AM +0400, Sergei Shtylyov wrote: [...] This controller does not integrate the root hub, so this driver also fakes one-port hub. External hub is required to support more than one device. ... Please, no. What exactly 'no'? ;-) No

Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller

2008-09-19 Thread Andrew Morton
On Thu, 18 Sep 2008 19:17:46 +0400 Anton Vorontsov [EMAIL PROTECTED] wrote: This patch adds support for the FHCI USB controller, as found in the Freescale MPC836x and MPC832x processors. It can support Full or Low speed modes. Quite a lot the hardware is doing by itself (SOF generation, CRC