Re: [Openipmi-developer] [PATCH 3/4] ipmi: allow dynamic BMC version information

2016-09-13 Thread Jeremy Kerr
Hi Corey, > In all, this looks good. I have two minor nits inline below, and > two more major comments here: > > I would prefer if it always queried the data, even if the device id > information is provided by the lower level driver. OK, can do. I was concerned that the SMI driver may want to

Re: [Openipmi-developer] [PATCH 3/4] ipmi: allow dynamic BMC version information

2016-09-12 Thread Corey Minyard
On 09/12/2016 03:55 AM, Jeremy Kerr wrote: Currently, it's up to the IPMI SMIs to provide the product & version details of BMCs behind registered IPMI SMI interfaces. This device ID is provided on SMI regsitration, and kept around for all future queries. However, this version information isn't

[PATCH 3/4] ipmi: allow dynamic BMC version information

2016-09-12 Thread Jeremy Kerr
Currently, it's up to the IPMI SMIs to provide the product & version details of BMCs behind registered IPMI SMI interfaces. This device ID is provided on SMI regsitration, and kept around for all future queries. However, this version information isn't always static. For example, a BMC may be