Re: [PATCH 3/6] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump

2020-04-06 Thread Christoph Hellwig
On Mon, Apr 06, 2020 at 02:02:38PM +0100, Al Viro wrote: > On Mon, Apr 06, 2020 at 02:03:09PM +0200, Christoph Hellwig wrote: > > There is no logic in elf_core_dump itself that uses uaccess routines > > on kernel pointers, the file writes are nicely encapsulated in dump_emit > > which does its own

Re: [PATCH 3/6] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump

2020-04-06 Thread Al Viro
On Mon, Apr 06, 2020 at 02:03:09PM +0200, Christoph Hellwig wrote: > There is no logic in elf_core_dump itself that uses uaccess routines > on kernel pointers, the file writes are nicely encapsulated in dump_emit > which does its own set_fs. ... assuming you've checked the asm/elf.h to see that no

[PATCH 3/6] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump

2020-04-06 Thread Christoph Hellwig
There is no logic in elf_core_dump itself that uses uaccess routines on kernel pointers, the file writes are nicely encapsulated in dump_emit which does its own set_fs. Signed-off-by: Christoph Hellwig --- fs/binfmt_elf.c | 40 +--- 1 file changed, 13 insertio