RE: [PATCH 3/6] powerpc/powernv: Replace variables with flags

2013-06-26 Thread David Laight
We have 2 fields in struct pnv_phb to trace the states. The patch replace the fields with one and introduces flags for that. The patch doesn't impact the logic. What is the benefit of this change? ... + +#define PNV_EEH_STATE_ENABLED(1 0)/* EEH enabled */ +#define

Re: [PATCH 3/6] powerpc/powernv: Replace variables with flags

2013-06-26 Thread Gavin Shan
On Wed, Jun 26, 2013 at 10:12:16AM +0100, David Laight wrote: We have 2 fields in struct pnv_phb to trace the states. The patch replace the fields with one and introduces flags for that. The patch doesn't impact the logic. What is the benefit of this change? There might have more flags

[PATCH 3/6] powerpc/powernv: Replace variables with flags

2013-06-25 Thread Gavin Shan
We have 2 fields in struct pnv_phb to trace the states. The patch replace the fields with one and introduces flags for that. The patch doesn't impact the logic. Signed-off-by: Gavin Shan sha...@linux.vnet.ibm.com --- arch/powerpc/platforms/powernv/eeh-ioda.c |8

[PATCH 3/6] powerpc/powernv: Replace variables with flags

2013-06-25 Thread Gavin Shan
We have 2 fields in struct pnv_phb to trace the states. The patch replace the fields with one and introduces flags for that. The patch doesn't impact the logic. Signed-off-by: Gavin Shan sha...@linux.vnet.ibm.com --- arch/powerpc/platforms/powernv/eeh-ioda.c |8