Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-21 Thread Paolo Bonzini
On Mon, Nov 20, 2023 at 3:09 PM Mark Brown wrote: > > On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > > __x86_64__, while the usages

Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-20 Thread Mark Brown
On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. > > Should > > On Sun, Nov 5, 2023 at 8:35 

Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-09 Thread Fuad Tabba
Hi Anish, On Thu, Nov 9, 2023 at 1:08 AM Anish Moorthy wrote: > > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. > > Should > > On Sun, Nov 5, 2023 at

Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-08 Thread Anish Moorthy
Applying [1] and [2] reveals that this also breaks non-x86 builds- the MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef __x86_64__, while the usages introduced here aren't. Should On Sun, Nov 5, 2023 at 8:35 AM Paolo Bonzini wrote: > > + test_invalid_memory_region_flags(); be

[PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-05 Thread Paolo Bonzini
From: Sean Christopherson Add a subtest to set_memory_region_test to verify that KVM rejects invalid flags and combinations with -EINVAL. KVM might or might not fail with EINVAL anyways, but we can at least try. Signed-off-by: Sean Christopherson Message-Id: