Re: [PATCH 4/4] powerpc: Remove CONFIG_POWER4_ONLY

2012-04-18 Thread Benjamin Herrenschmidt
On Wed, 2012-04-18 at 14:46 +1000, Anton Blanchard wrote: + ALT_FTR_SECTION_END_NESTED_IFCLR((CPU_FTR_PPCAS_ARCH_V2), 487) So if I remember properly, this means you key off if both CPU_FTR_NOEXECUTE and CPU_FTR_NODISRALIGN are clear... is there a point ? You make the patch simpler by only

Re: [PATCH 4/4] powerpc: Remove CONFIG_POWER4_ONLY

2012-04-18 Thread Anton Blanchard
Hi Ben, So if I remember properly, this means you key off if both CPU_FTR_NOEXECUTE and CPU_FTR_NODISRALIGN are clear... is there a point ? You make the patch simpler by only keying on NO_EXECUTE which afaik is a power4 or later only feature no ? Was going to do that, but noticed ARCH_V2

Re: [PATCH 4/4] powerpc: Remove CONFIG_POWER4_ONLY

2012-04-18 Thread Benjamin Herrenschmidt
On Wed, 2012-04-18 at 16:51 +1000, Anton Blanchard wrote: arch/powerpc/kernel/sysfs.c: if (cpu_has_feature(CPU_FTR_PPCAS_ARCH_V2)) I'm ok either way, should I respin to use CPU_FTR_NO_EXECUTE? Yeah, that sysfs bit will be true if -either- of the two bits is true, which is yet another

[PATCH 4/4] powerpc: Remove CONFIG_POWER4_ONLY

2012-04-18 Thread Anton Blanchard
Remove CONFIG_POWER4_ONLY, the option is badly named and only does two things: - It wraps the MMU segment table code. With feature fixups there is little downside to compiling this in. - It uses the newer mtocrf instruction in various assembly functions. Instead of making this a compile

[PATCH 4/4] powerpc: Remove CONFIG_POWER4_ONLY

2012-04-17 Thread Anton Blanchard
Remove CONFIG_POWER4_ONLY, the option is badly named and only does two things: - It wraps the MMU segment table code. With feature fixups there is little downside to compiling this in. - It uses the newer mtocrf instruction in various assembly functions. Instead of making this a compile