Re: [PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-12-11 Thread Mark A. Greer
On Thu, Nov 29, 2007 at 06:42:00PM +0300, Andrei Dolnikov wrote: Emerson Katana Qp platform specific code Signed-off-by: Andrei Dolnikov [EMAIL PROTECTED] Acked-by: Mark A. Greer [EMAIL PROTECTED] ___ Linuxppc-dev mailing list

Re: [PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-12-03 Thread Benjamin Herrenschmidt
On Thu, 2007-11-29 at 18:42 +0300, Andrei Dolnikov wrote: +config PPC_KATANAQP + bool Emerson-Katana Qp + depends on EMBEDDED6xx + select MV64X60 + select NOT_COHERENT_CACHE ^^ Just one word: ARG ! Oh and another one: WHY ?

Re: [PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-12-03 Thread Mark A. Greer
On Tue, Dec 04, 2007 at 07:54:59AM +1100, Benjamin Herrenschmidt wrote: On Thu, 2007-11-29 at 18:42 +0300, Andrei Dolnikov wrote: +config PPC_KATANAQP + bool Emerson-Katana Qp + depends on EMBEDDED6xx + select MV64X60 + select NOT_COHERENT_CACHE

[PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-11-29 Thread Andrei Dolnikov
Emerson Katana Qp platform specific code Signed-off-by: Andrei Dolnikov [EMAIL PROTECTED] --- Kconfig|9 +++ Makefile |1 katanaqp.c | 168 + 3 files changed, 178 insertions(+) diff --git

Re: [PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-11-24 Thread Arnd Bergmann
On Friday 16 November 2007, Andrei Dolnikov wrote: +static int __init katanaqp_is_monarch(void) +{ + return !(in_8((volatile char *)(cpld_base + KATANAQP_CPLD_PSR)) + KATANAQP_CPLD_PSR_PMCM); +} The pointer here needs to be __iomem, not volatile. Same in other places.

Re: [PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-11-24 Thread Benjamin Herrenschmidt
On Sat, 2007-11-24 at 19:51 +0100, Arnd Bergmann wrote: This should be done automatically using of_platform_bus_probe(). Not necessarily. of_platform_bus_probe() is an optional facility that is common used by SoCs that have lots of otherwise non-probable on chip devices, but for platforms

Re: [PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-11-21 Thread Vitaly Bordug
Hi Andrei, Looks okay in general, some notes below... On Fri, 16 Nov 2007 19:31:16 +0300 Andrei Dolnikov wrote: Emerson Katana Qp platform specific code Signed-off-by: Andrei Dolnikov [EMAIL PROTECTED] --- arch/powerpc/platforms/embedded6xx/Kconfig|9 +

[PATCH 4/5] PowerPC 74xx: Katana Qp base support

2007-11-16 Thread Andrei Dolnikov
Emerson Katana Qp platform specific code Signed-off-by: Andrei Dolnikov [EMAIL PROTECTED] --- arch/powerpc/platforms/embedded6xx/Kconfig|9 + arch/powerpc/platforms/embedded6xx/Makefile |1 arch/powerpc/platforms/embedded6xx/katanaqp.c | 180 ++ 3 files