Re: [PATCH 4/8] drivers/i2c/busses/i2c-pasemi.c: Fix unsigned return type

2010-09-06 Thread Olof Johansson
On Sun, Sep 05, 2010 at 09:00:22PM +0200, Julia Lawall wrote: The function has an unsigned return type, but returns a negative constant to indicate an error condition. The result of calling the function is always stored in a variable of type (signed) int, and thus unsigned can be dropped from

[PATCH 4/8] drivers/i2c/busses/i2c-pasemi.c: Fix unsigned return type

2010-09-05 Thread Julia Lawall
The function has an unsigned return type, but returns a negative constant to indicate an error condition. The result of calling the function is always stored in a variable of type (signed) int, and thus unsigned can be dropped from the return type. A sematic match that finds this problem is as