Re: [PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family

2009-06-18 Thread Kumar Gala
On Jun 17, 2009, at 6:24 PM, Paul Mackerras wrote: Kumar Gala writes: This should be something like: obj64-$(CONFIG_PPC_PERF_CTRS)-$(PPC_BOOK3S_64) +obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj32-$(CONFIG_PPC_PERF_CTRS)-$(PPC_BOOK3S_32) Or use new Kconfig types as I suggested on

Re: [PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family

2009-06-18 Thread Paul Mackerras
Kumar Gala writes: In looking at doing this what suggestions do you have in implementing perf_instruction_pointer() if we don't have the equivalent of SIAR. Just use regs-nip ? Yes, exactly. If you don't have SIAR/SDAR/MMCRA, the default definitions for perf_instruction_pointer and

[PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family

2009-06-17 Thread Paul Mackerras
This adds support for the performance monitor hardware on the MPC7450 family of processors (7450, 7451, 7455, 7447/7457, 7447A, 7448), used in the later Apple G4 powermacs/powerbooks and other machines. These machines have 6 hardware counters with a unique set of events which can be counted on

Re: [PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family

2009-06-17 Thread Kumar Gala
On Jun 17, 2009, at 6:53 AM, Paul Mackerras wrote: This adds support for the performance monitor hardware on the MPC7450 family of processors (7450, 7451, 7455, 7447/7457, 7447A, 7448), used in the later Apple G4 powermacs/powerbooks and other machines. These machines have 6 hardware counters

Re: [PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family

2009-06-17 Thread Paul Mackerras
Kumar Gala writes: This should be something like: obj64-$(CONFIG_PPC_PERF_CTRS)-$(PPC_BOOK3S_64) +obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj32-$(CONFIG_PPC_PERF_CTRS)-$(PPC_BOOK3S_32) Or use new Kconfig types as I suggested on patch 1/6 Feel free to send a patch making