Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-02 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 7:41 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Tue, Mar 31, 2009 at 6:37 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old fixed clock settings will be used for backward

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable and easier to extend code.  It also adds lets the compiler do more type checking for you. OK but I

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable and easier to extend code. It also adds lets the compiler do more type

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable and easier to extend code. It also adds lets the

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 7:41 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable

[PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
This patch makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old fixed clock settings will be used for backward comptibility. The generic I2C clock properties, especially the CPU-specific source clock pre-scaler are defined

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 6:37 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old fixed clock settings will be used for backward comptibility. The generic I2C