Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-08 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | bool is_load_store(int ext_opcode) | { | upper = ext_opcode 5; | lower = ext_opcode 0x1f; | | /* Short circuit as many misses as we can */ | if (lower 3 || lower 23) | return false; I see some

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-08 Thread Michael Ellerman
On Tue, 2013-10-08 at 12:31 -0700, Sukadev Bhattiprolu wrote: Michael Ellerman [mich...@ellerman.id.au] wrote: | bool is_load_store(int ext_opcode) | { | upper = ext_opcode 5; | lower = ext_opcode 0x1f; | | /* Short circuit as many misses as we can */ |

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-08 Thread Michael Ellerman
On Wed, Oct 09, 2013 at 12:03:19PM +1100, Michael Ellerman wrote: On Tue, 2013-10-08 at 12:31 -0700, Sukadev Bhattiprolu wrote: Michael Ellerman [mich...@ellerman.id.au] wrote: | bool is_load_store(int ext_opcode) | { | upper = ext_opcode 5; | lower = ext_opcode 0x1f;

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-07 Thread Michael Ellerman
On Thu, 2013-10-03 at 14:52 -0500, Tom Musta wrote: On 10/3/2013 2:03 PM, Sukadev Bhattiprolu wrote: Michael Ellerman [mich...@ellerman.id.au] wrote: snip | | if (lower == 6) | if (upper = 1) | return true; | return false; v Note

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-07 Thread Michael Ellerman
On Thu, Oct 03, 2013 at 12:03:25PM -0700, Sukadev Bhattiprolu wrote: Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:06PM -0700, Sukadev Bhattiprolu wrote: | Implement is_instr_load_store() to detect whether a given instruction | is one of the fixed-point or

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:06PM -0700, Sukadev Bhattiprolu wrote: | Implement is_instr_load_store() to detect whether a given instruction | is one of the fixed-point or floating-point load/store instructions. | This function will be used in

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-03 Thread Tom Musta
On 10/3/2013 2:03 PM, Sukadev Bhattiprolu wrote: Michael Ellerman [mich...@ellerman.id.au] wrote: snip | | if (lower == 6) | if (upper = 1) | return true; | return false; v Note that this case covers the lvsl/lvsr instructions, which, despite

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-02 Thread Michael Ellerman
On Tue, Oct 01, 2013 at 05:15:06PM -0700, Sukadev Bhattiprolu wrote: Implement is_instr_load_store() to detect whether a given instruction is one of the fixed-point or floating-point load/store instructions. This function will be used in a follow-on patch to save memory hierarchy information

[PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-01 Thread Sukadev Bhattiprolu
Implement is_instr_load_store() to detect whether a given instruction is one of the fixed-point or floating-point load/store instructions. This function will be used in a follow-on patch to save memory hierarchy information of the load/store. Signed-off-by: Sukadev Bhattiprolu