Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-11-23 Thread Kumar Gala
On Aug 8, 2011, at 6:18 AM, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk At this point, ehv_pic has been allocated but not stored anywhere, so it should be freed before leaving the function. A simplified version of the semantic match that finds this problem is as follows:

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-23 Thread Timur Tabi
Julia Lawall wrote: At this point, ehv_pic has been allocated but not stored anywhere, so it should be freed before leaving the function. Acked-by: Timur Tabi ti...@freescale.com FYI, Ashish is no longer with Freescale, so I've taken over maintainership of ehv_pic. -- Timur Tabi Linux kernel

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-23 Thread Timur Tabi
Ben, Kumar, can one of you take a look at my question and help me out? wrote: On Mon, Aug 8, 2011 at 7:18 AM, Julia Lawall ju...@diku.dk wrote: diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c index af1a5df..b6731e4 100644 --- a/arch/powerpc/sysdev/ehv_pic.c +++

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-15 Thread Tabi Timur-B04825
On Mon, Aug 8, 2011 at 7:18 AM, Julia Lawall ju...@diku.dk wrote: diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c index af1a5df..b6731e4 100644 --- a/arch/powerpc/sysdev/ehv_pic.c +++ b/arch/powerpc/sysdev/ehv_pic.c @@ -280,6 +280,7 @@ void __init

[PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-08 Thread Julia Lawall
From: Julia Lawall ju...@diku.dk At this point, ehv_pic has been allocated but not stored anywhere, so it should be freed before leaving the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @exists@ local