Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-09-20 Thread Jan-Bernd Themann
Hi Milton, sorry for the delayed answer, was on vacation. linux-kernel-ow...@vger.kernel.org wrote on 21.05.2010 11:18:01: linux-kernel-ow...@vger.kernel.org On Thu, 20 May 2010 at 10:21:36 +0200 (CEST) Thomas Gleixner wrote: On Thu, 20 May 2010, Michael Ellerman wrote: On Wed,

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-21 Thread Milton Miller
On Thu, 20 May 2010 at 10:21:36 +0200 (CEST) Thomas Gleixner wrote: On Thu, 20 May 2010, Michael Ellerman wrote: On Wed, 2010-05-19 at 16:38 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-21 Thread Milton Miller
On Thu May 20 at 11:28:36 EST in 2010, Michael Ellerman wrote: On Wed, 2010-05-19 at 07:16 -0700, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Jan-Bernd Themann
Hi, Michael Ellerman mich...@ellerman.id.au wrote on 20.05.2010 03:34:08: Subject: Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) On Wed, 2010-05-19 at 23:08 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Thomas Gleixner wrote: I'm still not clear

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Thomas Gleixner
On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_ disable the rx interrupt in the card in the rx interrupt handler - for whatever reason. Yeah I saw that, but I don't know why it's written that way.

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Thomas Gleixner
On Thu, 20 May 2010, Michael Ellerman wrote: On Wed, 2010-05-19 at 16:38 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: The result of the discussion about

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Jan-Bernd Themann
Hi Thomas Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_ disable the rx interrupt in the card in the rx interrupt handler

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Thomas Gleixner
Jan-Bernd, On Thu, 20 May 2010, Jan-Bernd Themann wrote: Hi Thomas Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Nivedita Singhvi
Thomas Gleixner wrote: Pleaes check if multiple queues are enabled. The following module parameter is used for that: MODULE_PARM_DESC(use_mcs, 0:NAPI, 1:Multiple receive queues, Default = 0 ); you should also see the number of used HEA interrupts in /proc/interrupts I leave that for Will

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Darren Hart
On 05/20/2010 01:14 AM, Thomas Gleixner wrote: On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_ disable the rx interrupt in the card in the rx interrupt handler - for whatever reason. Yeah I saw that, but I don't

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Thomas Gleixner
On Thu, 20 May 2010, Darren Hart wrote: On 05/20/2010 01:14 AM, Thomas Gleixner wrote: On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_ disable the rx interrupt in the card in the rx interrupt

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Will Schmidt
On Thu, 2010-05-20 at 11:05 +0200, Jan-Bernd Themann wrote: Hi Thomas Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-20 Thread Will Schmidt
On Thu, 2010-05-20 at 16:45 +0200, Thomas Gleixner wrote: On Thu, 20 May 2010, Darren Hart wrote: On 05/20/2010 01:14 AM, Thomas Gleixner wrote: On Thu, 20 May 2010, Jan-Bernd Themann wrote: Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Darren Hart
On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline... Yes, it basically says don't make this handler threaded. That

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Thomas Gleixner
On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline... Yes, it

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Thomas Gleixner
On Wed, 19 May 2010, Thomas Gleixner wrote: I'm still not clear on why the ultimate solution wasn't to have XICS report edge triggered as edge triggered. Probably some complexity of the entire power stack that I am ignorant of. Apart from the issue of loosing interrupts there is

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 07:16 -0700, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline...

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 16:38 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 23:08 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Thomas Gleixner wrote: I'm still not clear on why the ultimate solution wasn't to have XICS report edge triggered as edge triggered. Probably some complexity of the entire power stack that I am

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-18 Thread Brian King
Subject: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) The underlying hardware is edge triggered but presented by XICS as level triggered. The edge triggered interrupts are not reissued after masking. This is not a problem in mainline which does not mask the interrupt

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-18 Thread Nivedita Singhvi
Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline... Yep, this is RT only. thanks, Nivedita ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-18 Thread Darren Hart
ad81664794e33d785f533c5edee37aaba20dd92d Mon Sep 17 00:00:00 2001 From: Darren Hartdvh...@us.ibm.com Date: Tue, 18 May 2010 11:07:13 -0700 Subject: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) The underlying hardware is edge triggered but presented by XICS as level triggered. The edge triggered

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-18 Thread Michael Ellerman
On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline... Yes, it basically says don't make this handler threaded. That is a good fix for EHEA, but the threaded