Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-12 Thread Bjorn Helgaas
On Wed, Jan 11, 2023 at 03:27:51PM -0800, Sathyanarayanan Kuppuswamy wrote: > On 1/11/23 3:10 PM, Bjorn Helgaas wrote: > > On Wed, Jan 11, 2023 at 01:42:21PM -0800, Sathyanarayanan Kuppuswamy wrote: > >> On 1/11/23 12:31 PM, Vidya Sagar wrote: > >>> As the ECRC configuration bits are part of AER

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Vidya Sagar
On 1/12/2023 10:36 AM, Sathyanarayanan Kuppuswamy wrote: External email: Use caution opening links or attachments On 1/11/23 8:59 PM, Vidya Sagar wrote: On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote: External email: Use caution opening links or attachments On 1/11/23 7:33 PM,

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Sathyanarayanan Kuppuswamy
On 1/11/23 8:59 PM, Vidya Sagar wrote: > > > On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote: >> External email: Use caution opening links or attachments >> >> >> On 1/11/23 7:33 PM, Vidya Sagar wrote: >>> I think we still need bios option. For example, consider a system where >>>

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Vidya Sagar
On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote: External email: Use caution opening links or attachments On 1/11/23 7:33 PM, Vidya Sagar wrote: I think we still need bios option. For example, consider a system where BIOS needs to keep ECRC enabled for integrity reasons but if

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Sathyanarayanan Kuppuswamy
On 1/11/23 7:33 PM, Vidya Sagar wrote: > I think we still need bios option. For example, consider a system where BIOS > needs to keep ECRC enabled for integrity reasons but if kernel doesn't want > it for perf reasons, then, kernel can always use 'ecrc=off' option. I agree that "on" and

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Vidya Sagar
On 1/12/2023 4:57 AM, Sathyanarayanan Kuppuswamy wrote: External email: Use caution opening links or attachments Hi, On 1/11/23 3:10 PM, Bjorn Helgaas wrote: On Wed, Jan 11, 2023 at 01:42:21PM -0800, Sathyanarayanan Kuppuswamy wrote: On 1/11/23 12:31 PM, Vidya Sagar wrote: As the ECRC

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Sathyanarayanan Kuppuswamy
Hi, On 1/11/23 3:10 PM, Bjorn Helgaas wrote: > On Wed, Jan 11, 2023 at 01:42:21PM -0800, Sathyanarayanan Kuppuswamy wrote: >> On 1/11/23 12:31 PM, Vidya Sagar wrote: >>> As the ECRC configuration bits are part of AER registers, configure >>> ECRC only if AER is natively owned by the kernel. >> >>

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Bjorn Helgaas
On Wed, Jan 11, 2023 at 01:42:21PM -0800, Sathyanarayanan Kuppuswamy wrote: > On 1/11/23 12:31 PM, Vidya Sagar wrote: > > As the ECRC configuration bits are part of AER registers, configure > > ECRC only if AER is natively owned by the kernel. > > ecrc command line option takes "bios/on/off" as

[PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Vidya Sagar
As the ECRC configuration bits are part of AER registers, configure ECRC only if AER is natively owned by the kernel. Signed-off-by: Vidya Sagar --- drivers/pci/pcie/aer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index

Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native

2023-01-11 Thread Sathyanarayanan Kuppuswamy
On 1/11/23 12:31 PM, Vidya Sagar wrote: > As the ECRC configuration bits are part of AER registers, configure > ECRC only if AER is natively owned by the kernel. ecrc command line option takes "bios/on/off" as possible options. It does not clarify whether "on/off" choices can only be used if