Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-14 Thread Benjamin Herrenschmidt
On Thu, 2014-02-13 at 08:03 +1100, Benjamin Herrenschmidt wrote: It looks very different because the function that needs to be fixed changed a lot upstream in 3.13. .../... Hi Greg ! You didn't say if that explanation was to your liking :-) If it is, do you want Aneesh to re-submit the

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-12 Thread Greg KH
On Wed, Feb 12, 2014 at 08:22:02AM +0530, Aneesh Kumar K.V wrote: Greg KH gre...@linuxfoundation.org writes: On Fri, Feb 07, 2014 at 07:21:57PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-12 Thread Aneesh Kumar K.V
Greg KH gre...@linuxfoundation.org writes: On Wed, Feb 12, 2014 at 08:22:02AM +0530, Aneesh Kumar K.V wrote: Greg KH gre...@linuxfoundation.org writes: On Fri, Feb 07, 2014 at 07:21:57PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-12 Thread Benjamin Herrenschmidt
On Wed, 2014-02-12 at 06:23 -0800, Greg KH wrote: I have no idea what that means... If you want this patch applied, please be specific as to what is going on, why the code is _very_ different, and all of that. Make it _obvious_ as to what is happening, and why I would be a fool not to take

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-11 Thread Greg KH
On Fri, Feb 07, 2014 at 07:21:57PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac] .hash_page+0x18c/0x5e0 ... Call Trace: [c00736103c40]

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-11 Thread Benjamin Herrenschmidt
On Tue, 2014-02-11 at 09:31 -0800, Greg KH wrote: On Fri, Feb 07, 2014 at 07:21:57PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac]

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-11 Thread Aneesh Kumar K.V
Greg KH gre...@linuxfoundation.org writes: On Fri, Feb 07, 2014 at 07:21:57PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac]

Re: [PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-11 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Tue, 2014-02-11 at 09:31 -0800, Greg KH wrote: On Fri, Feb 07, 2014 at 07:21:57PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4]

[PATCH V2] powerpc: thp: Fix crash on mremap

2014-02-07 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac] .hash_page+0x18c/0x5e0 ... Call Trace: [c00736103c40] [1b00] 0x1b00(unreliable) [437908.479693]

[PATCH -V2] powerpc: thp: Fix crash on mremap

2014-01-02 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac] .hash_page+0x18c/0x5e0 ... Call Trace: [c00736103c40] [1b00] 0x1b00(unreliable) [437908.479693]

RE: [PATCH -V2] powerpc: thp: Fix crash on mremap

2014-01-02 Thread Kirill A. Shutemov
Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac] .hash_page+0x18c/0x5e0 ... Call Trace: [c00736103c40] [1b00] 0x1b00(unreliable)

RE: [PATCH -V2] powerpc: thp: Fix crash on mremap

2014-01-02 Thread Aneesh Kumar K.V
Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch fix the below crash NIP [c004cee4] .__hash_page_thp+0x2a4/0x440 LR [c00439ac] .hash_page+0x18c/0x5e0 ... Call Trace:

Re: [PATCH -V2] powerpc: thp: Fix crash on mremap

2014-01-02 Thread Benjamin Herrenschmidt
On Thu, 2014-01-02 at 16:22 +0530, Aneesh Kumar K.V wrote: Just use config option directly: if (new_ptl != old_ptl || IS_ENABLED(CONFIG_ARCH_THP_MOVE_PMD_ALWAYS_WITHDRAW)) I didn't like that. I found the earlier one easier for reading. If you and others strongly

Re: [PATCH -V2] powerpc: thp: Fix crash on mremap

2014-01-02 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Thu, 2014-01-02 at 16:22 +0530, Aneesh Kumar K.V wrote: Just use config option directly: if (new_ptl != old_ptl || IS_ENABLED(CONFIG_ARCH_THP_MOVE_PMD_ALWAYS_WITHDRAW)) I didn't like that. I found the