Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-18 Thread Suraj Jitindar Singh
On 18/07/16 18:24, Paolo Bonzini wrote: > > On 18/07/2016 09:17, Christian Borntraeger wrote: >> On 07/15/2016 09:52 AM, Suraj Jitindar Singh wrote: >>> >>> On 14/07/16 19:42, Paolo Bonzini wrote: On 13/07/2016 20:00, Christian Borntraeger wrote: > I thought u64 still existed on

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-18 Thread Paolo Bonzini
On 18/07/2016 09:17, Christian Borntraeger wrote: > On 07/15/2016 09:52 AM, Suraj Jitindar Singh wrote: >> >> >> On 14/07/16 19:42, Paolo Bonzini wrote: >>> >>> On 13/07/2016 20:00, Christian Borntraeger wrote: I thought u64 still existed on 32-bit architectures. unsigned long

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-18 Thread Christian Borntraeger
On 07/15/2016 09:52 AM, Suraj Jitindar Singh wrote: > > > On 14/07/16 19:42, Paolo Bonzini wrote: >> >> On 13/07/2016 20:00, Christian Borntraeger wrote: >>> I thought u64 still existed on 32-bit architectures. unsigned long >>> would be fine but with the caveat that certain stats would

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-15 Thread Suraj Jitindar Singh
On 14/07/16 19:42, Paolo Bonzini wrote: > > On 13/07/2016 20:00, Christian Borntraeger wrote: >> I thought u64 still existed on 32-bit architectures. unsigned long >> would be fine but with the caveat that certain stats would overflow on >> 32-bit architectures. Yes, but not all

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-14 Thread Paolo Bonzini
On 13/07/2016 20:00, Christian Borntraeger wrote: >>> >> I thought u64 still existed on 32-bit architectures. unsigned long >>> >> would be fine but with the caveat that certain stats would overflow on >>> >> 32-bit architectures. >> > >> > Yes, but not all 32-bit architectures can do atomic

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-13 Thread Christian Borntraeger
On 07/11/2016 09:31 PM, Paolo Bonzini wrote: > > > On 11/07/2016 19:30, David Matlack wrote: >> On Mon, Jul 11, 2016 at 10:05 AM, Paolo Bonzini wrote: >>> >>> >>> On 11/07/2016 18:51, David Matlack wrote: >> vcpus have statistics associated with them which can be viewed

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-12 Thread Suraj Jitindar Singh
On 12/07/16 05:45, David Matlack wrote: > On Mon, Jul 11, 2016 at 12:31 PM, Paolo Bonzini wrote: >> >> On 11/07/2016 19:30, David Matlack wrote: >>> On Mon, Jul 11, 2016 at 10:05 AM, Paolo Bonzini wrote: On 11/07/2016 18:51, David Matlack

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-11 Thread David Matlack via Linuxppc-dev
On Mon, Jul 11, 2016 at 12:31 PM, Paolo Bonzini wrote: > > > On 11/07/2016 19:30, David Matlack wrote: >> On Mon, Jul 11, 2016 at 10:05 AM, Paolo Bonzini wrote: >>> >>> >>> On 11/07/2016 18:51, David Matlack wrote: >> vcpus have statistics associated

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-11 Thread David Matlack
On Mon, Jul 11, 2016 at 10:05 AM, Paolo Bonzini wrote: > > > On 11/07/2016 18:51, David Matlack wrote: >>> > vcpus have statistics associated with them which can be viewed within the >>> > debugfs. Currently it is assumed within the vcpu_stat_get() and >>> >

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-11 Thread David Matlack
On Mon, Jul 11, 2016 at 12:08 AM, Suraj Jitindar Singh wrote: > vcpus have statistics associated with them which can be viewed within the > debugfs. Currently it is assumed within the vcpu_stat_get() and > vcpu_stat_get_per_vm() functions that all of these statistics are

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 19:30, David Matlack wrote: > On Mon, Jul 11, 2016 at 10:05 AM, Paolo Bonzini wrote: >> >> >> On 11/07/2016 18:51, David Matlack wrote: > vcpus have statistics associated with them which can be viewed within the > debugfs. Currently it is assumed

Re: [PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 18:51, David Matlack wrote: >> > vcpus have statistics associated with them which can be viewed within the >> > debugfs. Currently it is assumed within the vcpu_stat_get() and >> > vcpu_stat_get_per_vm() functions that all of these statistics are >> > represented as 32-bit numbers.

[PATCH V2 4/5] kvm/stats: Add provisioning for 64-bit vcpu statistics

2016-07-11 Thread Suraj Jitindar Singh
vcpus have statistics associated with them which can be viewed within the debugfs. Currently it is assumed within the vcpu_stat_get() and vcpu_stat_get_per_vm() functions that all of these statistics are represented as 32-bit numbers. The next patch adds some 64-bit statistics, so add provisioning