Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-02-07 Thread Anju T Sudhakar
Hi Michael, Thank you so much for the review. On Wednesday 01 February 2017 04:23 PM, Michael Ellerman wrote: Anju T Sudhakar writes: Detour buffer contains instructions to create an in memory pt_regs. After the execution of the pre-handler, a call is made for instruction emulation. The NI

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-02-06 Thread Naveen N. Rao
On 2017/02/07 10:05AM, Masami Hiramatsu wrote: > On Sat, 4 Feb 2017 01:09:49 +0530 > "Naveen N. Rao" wrote: > > > Hi Michael, > > Thanks for the review! I'll defer to Anju on most of the aspects, but... > > > > On 2017/02/01 09:53PM, Michael Ellerman wrote: > > > Anju T Sudhakar writes: > > >

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-02-06 Thread Masami Hiramatsu
On Sat, 4 Feb 2017 01:09:49 +0530 "Naveen N. Rao" wrote: > Hi Michael, > Thanks for the review! I'll defer to Anju on most of the aspects, but... > > On 2017/02/01 09:53PM, Michael Ellerman wrote: > > Anju T Sudhakar writes: > > > > > +static void optimized_callback(struct optimized_kprobe *op

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-02-03 Thread Naveen N. Rao
Hi Michael, Thanks for the review! I'll defer to Anju on most of the aspects, but... On 2017/02/01 09:53PM, Michael Ellerman wrote: > Anju T Sudhakar writes: > > > +static void optimized_callback(struct optimized_kprobe *op, > > + struct pt_regs *regs) > > +{ > > + str

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-02-01 Thread Michael Ellerman
Anju T Sudhakar writes: > Detour buffer contains instructions to create an in memory pt_regs. > After the execution of the pre-handler, a call is made for instruction > emulation. > The NIP is determined in advanced through dummy instruction emulation and a > branch > instruction is created to

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-01-30 Thread Naveen N. Rao
On 2017/01/31 07:43AM, Michael Ellerman wrote: > Anju T Sudhakar writes: > > > Detour buffer contains instructions to create an in memory pt_regs. > > After the execution of the pre-handler, a call is made for instruction > > emulation. > > The NIP is determined in advanced through dummy instruc

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-01-30 Thread Michael Ellerman
Anju T Sudhakar writes: > Detour buffer contains instructions to create an in memory pt_regs. > After the execution of the pre-handler, a call is made for instruction > emulation. > The NIP is determined in advanced through dummy instruction emulation and a > branch > instruction is created to

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-01-04 Thread Naveen N. Rao
On 2016/12/25 11:54AM, Masami Hiramatsu wrote: > On Mon, 19 Dec 2016 18:48:24 +0530 > Anju T Sudhakar wrote: > > > Detour buffer contains instructions to create an in memory pt_regs. > > After the execution of the pre-handler, a call is made for instruction > > emulation. > > The NIP is determin

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2016-12-24 Thread Masami Hiramatsu
On Mon, 19 Dec 2016 18:48:24 +0530 Anju T Sudhakar wrote: > Detour buffer contains instructions to create an in memory pt_regs. > After the execution of the pre-handler, a call is made for instruction > emulation. > The NIP is determined in advanced through dummy instruction emulation and a > b

[PATCH V3 3/4] arch/powerpc: Implement Optprobes

2016-12-19 Thread Anju T Sudhakar
Detour buffer contains instructions to create an in memory pt_regs. After the execution of the pre-handler, a call is made for instruction emulation. The NIP is determined in advanced through dummy instruction emulation and a branch instruction is created to the NIP at the end of the trampoline.