Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200

2009-05-26 Thread Mark Brown
On Mon, May 25, 2009 at 10:44:12PM -0500, Timur Tabi wrote: On Mon, May 25, 2009 at 5:15 PM, Jon Smirl jonsm...@gmail.com wrote: ? ? ?The macro spin_event_timeout() takes a condition and timeout value My patch is already set to go through the powerpc tree, so there's no need to repost it

Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200

2009-05-26 Thread Mark Brown
On Mon, May 25, 2009 at 06:15:05PM -0400, Jon Smirl wrote: reset retries. Removing the retries makes the driver fail to load about 5% of the time. An oscilliscope is Please also send a patch sorting this out in the STAC9766 driver as requested. Other than that and the udelay() thing it

Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200

2009-05-26 Thread Jon Smirl
On Mon, May 25, 2009 at 11:44 PM, Timur Tabi ti...@freescale.com wrote: On Mon, May 25, 2009 at 5:15 PM, Jon Smirl jonsm...@gmail.com wrote:      The macro spin_event_timeout() takes a condition and timeout value My patch is already set to go through the powerpc tree, so there's no need to

Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200

2009-05-26 Thread Timur Tabi
On Tue, May 26, 2009 at 6:08 AM, Jon Smirl jonsm...@gmail.com wrote: On Mon, May 25, 2009 at 11:44 PM, Timur Tabi ti...@freescale.com wrote: On Mon, May 25, 2009 at 5:15 PM, Jon Smirl jonsm...@gmail.com wrote:      The macro spin_event_timeout() takes a condition and timeout value My patch

Re: [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200

2009-05-26 Thread Mark Brown
On Tue, May 26, 2009 at 07:08:52AM -0400, Jon Smirl wrote: On Mon, May 25, 2009 at 11:44 PM, Timur Tabi ti...@freescale.com wrote: My patch is already set to go through the powerpc tree, so there's no need to repost it here. ?Please, you changed the title of the patch. I'm changing the

[PATCH V4 0/5] AC97 driver for mpc5200

2009-05-25 Thread Jon Smirl
Version 4. Changed timeouts to use relax_cpu() instead of udelay(). Fixed locking to lock bestcomm instead of registers. Code reorg as requested in the various comments. Removed sysfs over/underrun reporting. Removed reset retries. Removing the retries makes the driver fail to load about 5% of