Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Alexey Kardashevskiy
On 04/06/2019 09:42, Segher Boessenkool wrote: > Hi! > > On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote: >> On 03/06/2019 09:23, Segher Boessenkool wrote: So I go for the simple one and agree with Alexey's idea. >>> >>> When dealing with a whole device tree you have

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread David Gibson
On Mon, Jun 03, 2019 at 06:49:32PM -0500, Segher Boessenkool wrote: > On Tue, Jun 04, 2019 at 07:18:42AM +1000, Benjamin Herrenschmidt wrote: > > Yes we could make property fetching faster but mostly by creating a new > > bulk interface which is quite a bit of work, a new API, and will in > >

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Benjamin Herrenschmidt
On Mon, 2019-06-03 at 18:42 -0500, Segher Boessenkool wrote: > Hi! > > On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote: > > On 03/06/2019 09:23, Segher Boessenkool wrote: > > > > So I go for the simple one and agree with Alexey's idea. > > > > > > When dealing with a whole

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Segher Boessenkool
On Tue, Jun 04, 2019 at 07:18:42AM +1000, Benjamin Herrenschmidt wrote: > Yes we could make property fetching faster but mostly by creating a new > bulk interface which is quite a bit of work, a new API, and will in > practice not be used for anything other than creating the FDT. In that > case,

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Segher Boessenkool
Hi! On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote: > On 03/06/2019 09:23, Segher Boessenkool wrote: > >> So I go for the simple one and agree with Alexey's idea. > > > > When dealing with a whole device tree you have to know about the various > > dynamically generated

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-03 Thread Benjamin Herrenschmidt
On Mon, 2019-06-03 at 12:56 +1000, Alexey Kardashevskiy wrote: > > > That is all you need if you do not want to use OF at all. > > ? We also need OF drivers to boot grub and the system, and a default > console for early booting, but yes, we do not want to keep using slof > that much. > > > If

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-02 Thread Alexey Kardashevskiy
On 03/06/2019 09:23, Segher Boessenkool wrote: > Hi! > > On Fri, May 31, 2019 at 11:03:26AM +1000, Benjamin Herrenschmidt wrote: >> On Thu, 2019-05-30 at 14:37 -0500, Segher Boessenkool wrote: >>> On Thu, May 30, 2019 at 05:09:06PM +1000, Alexey Kardashevskiy wrote: so, it is sort-of nack

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-06-02 Thread Segher Boessenkool
Hi! On Fri, May 31, 2019 at 11:03:26AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2019-05-30 at 14:37 -0500, Segher Boessenkool wrote: > > On Thu, May 30, 2019 at 05:09:06PM +1000, Alexey Kardashevskiy wrote: > > > so, it is sort-of nack from David and sort-of ack from Segher, what > > >

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-30 Thread Benjamin Herrenschmidt
On Thu, 2019-05-30 at 14:37 -0500, Segher Boessenkool wrote: > On Thu, May 30, 2019 at 05:09:06PM +1000, Alexey Kardashevskiy wrote: > > so, it is sort-of nack from David and sort-of ack from Segher, what > > happens now? > > Maybe what we really need just a CI call to get all properties of a

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-30 Thread Segher Boessenkool
On Thu, May 30, 2019 at 05:09:06PM +1000, Alexey Kardashevskiy wrote: > so, it is sort-of nack from David and sort-of ack from Segher, what > happens now? Maybe what we really need just a CI call to get all properties of a node at once? Will that speed up things enough? That way you need no

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-30 Thread Alexey Kardashevskiy
so, it is sort-of nack from David and sort-of ack from Segher, what happens now? On 01/05/2019 13:42, Alexey Kardashevskiy wrote: > At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > about 8.5sec to fetch the entire device tree via the client interface > as the DT is

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-05 Thread Alexey Kardashevskiy
On 03/05/2019 12:35, David Gibson wrote: > On Fri, May 03, 2019 at 10:10:57AM +1000, Stewart Smith wrote: >> David Gibson writes: >>> On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: At the moment, on 256CPU + 256 PCI devices guest, it takes the guest about

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-03 Thread Segher Boessenkool
On Fri, May 03, 2019 at 10:10:57AM +1000, Stewart Smith wrote: > David Gibson writes: > > On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: > >> At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > >> about 8.5sec to fetch the entire device tree via the

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-03 Thread Segher Boessenkool
On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: > At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > about 8.5sec to fetch the entire device tree via the client interface > as the DT is traversed twice - for strings blob and for struct blob. > Also,

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-02 Thread David Gibson
On Fri, May 03, 2019 at 10:10:57AM +1000, Stewart Smith wrote: > David Gibson writes: > > On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: > >> At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > >> about 8.5sec to fetch the entire device tree via the

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-02 Thread Stewart Smith
David Gibson writes: > On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: >> At the moment, on 256CPU + 256 PCI devices guest, it takes the guest >> about 8.5sec to fetch the entire device tree via the client interface >> as the DT is traversed twice - for strings blob and for

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-02 Thread David Gibson
On Wed, May 01, 2019 at 01:42:21PM +1000, Alexey Kardashevskiy wrote: > At the moment, on 256CPU + 256 PCI devices guest, it takes the guest > about 8.5sec to fetch the entire device tree via the client interface > as the DT is traversed twice - for strings blob and for struct blob. > Also,

[PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-04-30 Thread Alexey Kardashevskiy
At the moment, on 256CPU + 256 PCI devices guest, it takes the guest about 8.5sec to fetch the entire device tree via the client interface as the DT is traversed twice - for strings blob and for struct blob. Also, "getprop" is quite slow too as SLOF stores properties in a linked list. However,