Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-08-02 Thread Mike Turquette
Quoting Nicolas Pitre (2013-07-18 10:47:22) On Thu, 18 Jul 2013, Russell King - ARM Linux wrote: 1. clk_get() and clk_put() are NOT part of the common clock API. They're separate - they're part of the clk API, and the infrastructure behind that is clkdev, which is a separately owned

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Gerhard Sittig
On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote: On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote: diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 6d55eb2..2c07061 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Sascha Hauer
On Thu, Jul 18, 2013 at 09:04:02AM +0200, Gerhard Sittig wrote: On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote: On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote: diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 6d55eb2..2c07061 100644

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Russell King - ARM Linux
On Thu, Jul 18, 2013 at 09:04:02AM +0200, Gerhard Sittig wrote: The common clock API assumes (it's part of the contract) that there are potentially expensive operations like get, put, prepare and unprepare, as well as swift and non-blocking operations like enable and disable. Let's get

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Mark Brown
On Thu, Jul 18, 2013 at 10:06:57AM +0200, Sascha Hauer wrote: I think regmap has the potential to solve a number of issues like the hardcoded readl/writel in the common clock blocks, issues with i2c clocks and your endianess issue. The biggest question probably is how to get there without

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Nicolas Pitre
On Thu, 18 Jul 2013, Russell King - ARM Linux wrote: 1. clk_get() and clk_put() are NOT part of the common clock API. They're separate - they're part of the clk API, and the infrastructure behind that is clkdev, which is a separately owned thing (by me.) 2. The contract of the clk API

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-17 Thread Gerhard Sittig
On Mon, Jul 15, 2013 at 21:38 +0200, Sascha Hauer wrote: On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote: diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 6d55eb2..2c07061 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@

[PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-15 Thread Gerhard Sittig
the common clock drivers were motivated/initiated by ARM development and apparently assume little endian peripherals wrap register/peripherals access in the common code (div, gate, mux) in preparation of adding COMMON_CLK support for other platforms Signed-off-by: Gerhard Sittig g...@denx.de ---

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-15 Thread Sascha Hauer
On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote: diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 6d55eb2..2c07061 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -104,7 +104,7 @@ static unsigned long