Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-06-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 03:05:31PM +0530, Aneesh Kumar K.V wrote: > On 4/16/21 2:39 PM, Andy Shevchenko wrote: > > On Fri, Apr 16, 2021 at 01:28:21PM +0530, Aneesh Kumar K.V wrote: > > > On 4/15/21 7:16 PM, Andy Shevchenko wrote: > > > > Parse to and export from UUID own type, before dereferencing.

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-16 Thread Vaibhav Jain
Andy Shevchenko writes: > On Thu, Apr 15, 2021 at 8:10 PM Vaibhav Jain wrote: >> >> >> Thanks for the patch Andy, >> >> Unfortunately ran into a compilation issue due to missing "#include >> " that provides definition for >> get_unaligned_le64(). Gcc reported following error: >> >> error: implic

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-16 Thread Aneesh Kumar K.V
On 4/16/21 2:39 PM, Andy Shevchenko wrote: On Fri, Apr 16, 2021 at 01:28:21PM +0530, Aneesh Kumar K.V wrote: On 4/15/21 7:16 PM, Andy Shevchenko wrote: Parse to and export from UUID own type, before dereferencing. This also fixes wrong comment (Little Endian UUID is something else) and should f

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 01:28:21PM +0530, Aneesh Kumar K.V wrote: > On 4/15/21 7:16 PM, Andy Shevchenko wrote: > > Parse to and export from UUID own type, before dereferencing. > > This also fixes wrong comment (Little Endian UUID is something else) > > and should fix Sparse warnings about assignin

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-16 Thread Aneesh Kumar K.V
On 4/15/21 7:16 PM, Andy Shevchenko wrote: Parse to and export from UUID own type, before dereferencing. This also fixes wrong comment (Little Endian UUID is something else) and should fix Sparse warnings about assigning strict types to POD. Fixes: 43001c52b603 ("powerpc/papr_scm: Use ibm,unit-g

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-15 Thread Aneesh Kumar K.V
On 4/15/21 7:16 PM, Andy Shevchenko wrote: Parse to and export from UUID own type, before dereferencing. This also fixes wrong comment (Little Endian UUID is something else) and should fix Sparse warnings about assigning strict types to POD. I am wondering whether this will break older namespa

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-15 Thread Andy Shevchenko
On Thu, Apr 15, 2021 at 8:10 PM Vaibhav Jain wrote: > > > Thanks for the patch Andy, > > Unfortunately ran into a compilation issue due to missing "#include > " that provides definition for > get_unaligned_le64(). Gcc reported following error: > > error: implicit declaration of function ‘get_unali

Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-15 Thread Vaibhav Jain
Thanks for the patch Andy, Unfortunately ran into a compilation issue due to missing "#include " that provides definition for get_unaligned_le64(). Gcc reported following error: error: implicit declaration of function ‘get_unaligned_le64’ After including the necessary header file, kernel comp

[PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API

2021-04-15 Thread Andy Shevchenko
Parse to and export from UUID own type, before dereferencing. This also fixes wrong comment (Little Endian UUID is something else) and should fix Sparse warnings about assigning strict types to POD. Fixes: 43001c52b603 ("powerpc/papr_scm: Use ibm,unit-guid as the iset cookie") Fixes: 259a948c4ba1