Re: [PATCH v13 17/24] selftests/vm: powerpc implementation to check support for pkey

2018-07-17 Thread Ram Pai
On Wed, Jun 20, 2018 at 08:09:12AM -0700, Dave Hansen wrote: > > - if (cpu_has_pku()) { > > - dprintf1("SKIP: %s: no CPU support\n", __func__); > > + if (is_pkey_supported()) { > > + dprintf1("SKIP: %s: no CPU/kernel support\n", __func__); > > return; > > }

Re: [PATCH v13 17/24] selftests/vm: powerpc implementation to check support for pkey

2018-06-20 Thread Dave Hansen
> - if (cpu_has_pku()) { > - dprintf1("SKIP: %s: no CPU support\n", __func__); > + if (is_pkey_supported()) { > + dprintf1("SKIP: %s: no CPU/kernel support\n", __func__); > return; > } I actually kinda wanted a specific message for when the

[PATCH v13 17/24] selftests/vm: powerpc implementation to check support for pkey

2018-06-13 Thread Ram Pai
pkey subsystem is supported if the hardware and kernel has support. We determine that by checking if allocation of a key succeeds or not. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/pkey-helpers.h|2 ++