Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-19 Thread Heiko Schocher
Hello Vitaly, Vitaly Bordug wrote: On Tue, 18 Mar 2008 09:04:14 +0100 Heiko Schocher wrote: [...] OK. Another thought about this. Shouldnt this table go in the dts? A device node like cpm_pin { pins = port pin flags; }; would be nice, or? This has been a disputable question some

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Heiko Schocher
Hello Stephen, Stephen Rothwell wrote: On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: [...] +struct cpm_pin { +int port, pin, flags; +}; I wish someone would consolidate all these definitions of cpm_pin. Hmm... do you mean something like, moving

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Stephen Rothwell
Hi Heiko, On Tue, 18 Mar 2008 08:13:06 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: Stephen Rothwell wrote: On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: [...] +struct cpm_pin { + int port, pin, flags; +}; I wish someone would consolidate all

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Heiko Schocher
Hello Stephen, Stephen Rothwell wrote: On Tue, 18 Mar 2008 08:13:06 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: Stephen Rothwell wrote: On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: [...] +struct cpm_pin { + int port, pin, flags; +}; I wish someone

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Scott Wood
On Tue, Mar 18, 2008 at 09:04:14AM +0100, Heiko Schocher wrote: OK. Another thought about this. Shouldnt this table go in the dts? A device node like cpm_pin { pins = port pin flags; }; would be nice, or? Well, the device tree is a mechanism for communicating from the firmware to

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Vitaly Bordug
On Tue, 18 Mar 2008 09:04:14 +0100 Heiko Schocher wrote: Hello Stephen, Stephen Rothwell wrote: On Tue, 18 Mar 2008 08:13:06 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: Stephen Rothwell wrote: On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: [...]

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Wolfgang Denk
Dear Scott, in message [EMAIL PROTECTED] you wrote: Well, the device tree is a mechanism for communicating from the firmware to the kernel, and if we could control the firmware better we'd just make it set the pins properly to begin with. :-) Is this just a comment, or do you oppose Heiko's

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-18 Thread Scott Wood
Wolfgang Denk wrote: Dear Scott, in message [EMAIL PROTECTED] you wrote: Well, the device tree is a mechanism for communicating from the firmware to the kernel, and if we could control the firmware better we'd just make it set the pins properly to begin with. :-) Is this just a comment, or

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-17 Thread Scott Wood
On Fri, Mar 14, 2008 at 10:24:30AM +0100, Heiko Schocher wrote: + setbits16(mpc8xx_immr-im_ioport.iop_pcso, 0x300); + cpm1_clk_setup(CPM_CLK_SCC3, CPM_CLK5, CPM_CLK_RX); + cpm1_clk_setup(CPM_CLK_SCC3, CPM_CLK6, CPM_CLK_TX); + setbits32(mpc8xx_immr-im_cpm.cp_pbpar, 0x300); +

[PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-14 Thread Heiko Schocher
Hello, This add support of the mgsuvd board from keymile to arch/powerpc. Supported SMC1 (serial console), SCC3 Ethernet (10Mbps hdx) Signed-off-by: Heiko Schocher [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mgsuvd.dts | 158 +++ arch/powerpc/configs/mgsuvd_defconfig | 827

Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

2008-03-14 Thread Stephen Rothwell
Hi Heiko, On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [EMAIL PROTECTED] wrote: This add support of the mgsuvd board from keymile to arch/powerpc. Supported SMC1 (serial console), SCC3 Ethernet (10Mbps hdx) Paul would probably like some description of the board here. +++