RE: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-15 Thread Kalra Ashish-B00888
Ashish-B00888 Subject: Re: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller On Friday 12 October 2007, Li Yang wrote: This patch adds support for Freescale 3.0Gbps SATA Controller supporting Native Command Queueing(NCQ), device hotplug, and ATAPI. This controller can

Re: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-15 Thread Arnd Bergmann
On Monday 15 October 2007, Kalra Ashish-B00888 wrote: Thanks for your comments and feedback. Actually, for PowerPC platforms iowrite32/ioread32 internally call writel/readl, which are again mapped to out_le32/in_le32, This is correct on 6xx and e500 for now, but it's a little more

RE: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-12 Thread Li Yang-r58472
-Original Message- From: Alan Cox [mailto:[EMAIL PROTECTED] Sent: Friday, October 12, 2007 9:55 PM To: Li Yang-r58472 Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org; Kalra Ashish-B00888; Li Yang-r58472 Subject: Re: [PATCH v2] drivers/ata: add support

Re: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-12 Thread Arnd Bergmann
On Friday 12 October 2007, Li Yang wrote: This patch adds support for Freescale 3.0Gbps SATA Controller supporting Native Command Queueing(NCQ), device hotplug, and ATAPI. This controller can be found on MPC8315 and MPC8378. Most of the driver looks really good, but here are a few things that

[PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-12 Thread Li Yang
From: Ashish Kalra [EMAIL PROTECTED] This patch adds support for Freescale 3.0Gbps SATA Controller supporting Native Command Queueing(NCQ), device hotplug, and ATAPI. This controller can be found on MPC8315 and MPC8378. Signed-off-by: Ashish Kalra [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL

Re: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-12 Thread Alan Cox
+ cd = pp-cmdentry + tag; + + memcpy(fis, cd-sfis, 6 * 4); /* should we use memcpy_from_io() */ If cd-sfis points at memory over the PCI bus (eg mmio or memory on the controller card) then you need to use ioread/_io type functions. If cd-sfis points into host memory where the FIS is

RE: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-12 Thread Kalra Ashish-B00888
PROTECTED]; [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org; Kalra Ashish-B00888; Li Yang-r58472 Subject: Re: [PATCH v2] drivers/ata: add support to Freescale 3.0Gbps SATA Controller + cd = pp-cmdentry + tag; + + memcpy(fis, cd-sfis, 6 * 4); /* should we use memcpy_from_io() */ If cd-sfis