Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-16 Thread Trent Piepho
On Tue, 15 Jul 2008, Richard Purdie wrote: > On Tue, 2008-07-15 at 18:23 +0400, Anton Vorontsov wrote: >>> Spell out openfirmware :). I initially had no idea "of == openfirmware" >>> and I suspect others won't either... >> >> This would be unusually long name, that is >> >> $ find . -iname '*openfi

Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-15 Thread Richard Purdie
On Tue, 2008-07-15 at 18:23 +0400, Anton Vorontsov wrote: > > Spell out openfirmware :). I initially had no idea "of == openfirmware" > > and I suspect others won't either... > > This would be unusually long name, that is > > $ find . -iname '*openfirmware*' | wc -l > 0 > > And in contrast: > >

Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-15 Thread Anton Vorontsov
On Tue, Jul 15, 2008 at 02:31:27PM +0100, Richard Purdie wrote: > On Tue, 2008-07-15 at 17:24 +0400, Anton Vorontsov wrote: > > On Tue, Jul 15, 2008 at 01:54:30PM +0100, Richard Purdie wrote: > > > I don't have any issue with the driver itself, just the name which is > > > going to confuse people n

Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-15 Thread Richard Purdie
On Tue, 2008-07-15 at 17:24 +0400, Anton Vorontsov wrote: > On Tue, Jul 15, 2008 at 01:54:30PM +0100, Richard Purdie wrote: > > I don't have any issue with the driver itself, just the name which is > > going to confuse people no end. > > > > Can we come up with a better name for this driver please

Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-15 Thread Anton Vorontsov
On Tue, Jul 15, 2008 at 01:54:30PM +0100, Richard Purdie wrote: > On Tue, 2008-07-15 at 16:40 +0400, Anton Vorontsov wrote: > > Despite leds-gpio and leds-of-gpio similar names and purposes, there > > is not much code can be shared between the two drivers (both are mostly > > driver bindings anyway

Re: [PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-15 Thread Richard Purdie
On Tue, 2008-07-15 at 16:40 +0400, Anton Vorontsov wrote: > Despite leds-gpio and leds-of-gpio similar names and purposes, there > is not much code can be shared between the two drivers (both are mostly > driver bindings anyway). I don't have any issue with the driver itself, just the name which i

[PATCH v2] leds: implement OpenFirmare GPIO LED driver

2008-07-15 Thread Anton Vorontsov
Despite leds-gpio and leds-of-gpio similar names and purposes, there is not much code can be shared between the two drivers (both are mostly driver bindings anyway). Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- Documentation/powerpc/dts-bindings/gpio/led.txt | 15 ++ drivers/leds/Kcon