On Thu, Jul 18, 2024 at 1:57 AM Luca Ceresoli wrote:
>
> Hello Stephen,
>
> On Wed, 17 Jul 2024 16:33:34 -0700
> Stephen Boyd wrote:
>
> > > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client
> > > *client,
> > > * property silabs,pll-source : , [<..>]
> > > *
Hello Stephen,
On Wed, 17 Jul 2024 16:33:34 -0700
Stephen Boyd wrote:
> > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client
> > *client,
> > * property silabs,pll-source : , [<..>]
> > * allow to selectively set pll source
> > */
> > - of_prop
Quoting Luca Ceresoli (2024-07-17 09:16:32)
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> index 4ce83c5265b8..d4904f59f83f 100644
> --- a/drivers/clk/clk-si5351.c
> +++ b/drivers/clk/clk-si5351.c
> @@ -1175,8 +1175,8 @@ static int si5351_dt_parse(struct i2c_client *client,
>
The of_property_for_each_u32() macro needs five parameters, two of which
are primarily meant as internal variables for the macro itself (in the
for() clause). Yet these two parameters are used by a few drivers, and this
can be considered misuse or at least bad practice.
Now that the kernel uses C1
