Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 21, 2017 at 04:19:11PM +0200, Milian Wolff escreveu: > On Mittwoch, 21. Juni 2017 14:48:29 CEST Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > > > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > > > Hi

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 14:48:29 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > > Hi Millian, can I take this as an Acked-by or Tested-by? > > > > I have no

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > Hi Millian, can I take this as an Acked-by or Tested-by? > I have no access to any PowerPC hardware. In principle the code looks > fine, but that's all

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > > Just a quick question: Have you guys applied my recent patch: > > > > commit

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Mark Wielaard
On Tue, Jun 20, 2017 at 10:06:35PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 01:16:32PM +0200, Mark Wielaard escreveu: > > On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote: > > > Just a quick question: Have you guys applied my recent patch: > > > > > > commit

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > Just a quick question: Have you guys applied my recent patch: > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > Author: Milian Wolff >

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 15, 2017 at 01:16:32PM +0200, Mark Wielaard escreveu: > On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote: > > Just a quick question: Have you guys applied my recent patch: > > > > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > > Author: Milian Wolff > >

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Ravi Bangoria
Works like a charm with Milian's patch. Acked-by: Ravi Bangoria Note: I still see very minor differences between libunwind and libdw. Also, second last function gets repeated two times in every callchain but it can be fixed later on. Otherwise all looks good!

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Mark Wielaard
On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote: > Just a quick question: Have you guys applied my recent patch: > > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > Author: Milian Wolff > Date: Thu Jun 1 23:00:21 2017 +0200 > > perf report: Include partial

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Milian Wolff
On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > Hi Mark, > > On Tuesday 13 June 2017 05:14 PM, Mark Wielaard wrote: > > I see the same on very short runs. But when doing a slightly longer run, > > even just using ls -lahR, which does some more work, then I do see user > >

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-13 Thread Ravi Bangoria
Hi Mark, On Tuesday 13 June 2017 05:14 PM, Mark Wielaard wrote: > I see the same on very short runs. But when doing a slightly longer run, > even just using ls -lahR, which does some more work, then I do see user > backtraces. They are still missing for some of the early samples though. > It is

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-13 Thread Mark Wielaard
Hi Ravi, On Mon, 2017-06-12 at 17:28 +0530, Ravi Bangoria wrote: > So, I tested this patch along with Mark's patch[1] on elfutils an looks > like it's not working. Steps on what I did: > > After applying Mark's patch on upstream elfutils: > > $ aclocal > $ autoheader > $ autoconf > $

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-12 Thread Ravi Bangoria
Hi Paolo, Thanks for the patch and really sorry for being late. I was quite busy with few other things. On Friday 09 June 2017 06:00 PM, Paolo Bonzini wrote: > > On 01/06/2017 12:24, Paolo Bonzini wrote: >> Porting PPC to libdw only needs an architecture-specific hook to move >> the register

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-09 Thread Paolo Bonzini
On 01/06/2017 12:24, Paolo Bonzini wrote: > Porting PPC to libdw only needs an architecture-specific hook to move > the register state from perf to libdw. > > The ARM and x86 architectures already use libdw, and it is useful to > have as much common code for the unwinder as possible. Mark