Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-20 Thread McClintock Matthew-B29882
On Fri, Dec 16, 2011 at 3:29 PM, Scott Wood scottw...@freescale.com wrote: On 12/15/2011 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2011-12-16 at 03:29 +, McClintock Matthew-B29882 wrote: On Thu, Dec 15, 2011 at 9:12 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon,

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-20 Thread Scott Wood
On 12/20/2011 12:44 PM, McClintock Matthew-B29882 wrote: On Fri, Dec 16, 2011 at 3:29 PM, Scott Wood scottw...@freescale.com wrote: It would be nice if we could eliminate all usage of the boot cpu dtb field -- it's easy to forget to set it, especially if you're not making an AMP config. The

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-16 Thread Scott Wood
On 12/15/2011 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2011-12-16 at 03:29 +, McClintock Matthew-B29882 wrote: On Thu, Dec 15, 2011 at 9:12 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2011-11-28 at 22:24 -0600, Matthew McClintock wrote: boot_cpuid and

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-16 Thread Benjamin Herrenschmidt
On Fri, 2011-12-16 at 15:29 -0600, Scott Wood wrote: It would be nice if we could eliminate all usage of the boot cpu dtb field -- it's easy to forget to set it, especially if you're not making an AMP config. The default -1 means this patch would break booting with such a tree. If we don't

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-15 Thread Benjamin Herrenschmidt
On Mon, 2011-11-28 at 22:24 -0600, Matthew McClintock wrote: boot_cpuid and init_thread_info.cpu are redundant, just use the var that stays around longer and add a define to make boot_cpuid point at the correct value boot_cpudid_phys is not needed and can completly go away from the SMP

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-15 Thread McClintock Matthew-B29882
On Thu, Dec 15, 2011 at 9:12 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2011-11-28 at 22:24 -0600, Matthew McClintock wrote: boot_cpuid and init_thread_info.cpu are redundant, just use the var that stays around longer and add a define to make boot_cpuid point at the

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-15 Thread Benjamin Herrenschmidt
On Fri, 2011-12-16 at 03:29 +, McClintock Matthew-B29882 wrote: On Thu, Dec 15, 2011 at 9:12 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2011-11-28 at 22:24 -0600, Matthew McClintock wrote: boot_cpuid and init_thread_info.cpu are redundant, just use the var that

Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-12-15 Thread McClintock Matthew-B29882
On Thu, Dec 15, 2011 at 9:35 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: This is 4/5 which is also waiting for your review. http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-October/093474.html Ah missed that. This is FSL specific, I'd need Kumar and/or Scott's ack for that

[PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}

2011-11-28 Thread Matthew McClintock
boot_cpuid and init_thread_info.cpu are redundant, just use the var that stays around longer and add a define to make boot_cpuid point at the correct value boot_cpudid_phys is not needed and can completly go away from the SMP case, we leave it there for the non-SMP case since the paca struct is