Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-21 Thread Peter Zijlstra
On Fri, Apr 17, 2020 at 09:26:56AM -0400, Qian Cai wrote: > > Acked-by: Michael Ellerman (powerpc) > > Peter, can you take a look at this patch when you have a chance? Sorry, -ETOOMUCHEMAIL, got it now, thanks!

Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-17 Thread Qian Cai
> On Apr 2, 2020, at 7:24 AM, Michael Ellerman wrote: > > Qian Cai writes: >> From: Peter Zijlstra >> >> In the CPU-offline process, it calls mmdrop() after idle entry and the >> subsequent call to cpuhp_report_idle_dead(). Once execution passes the >> call to rcu_report_dead(), RCU is

Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-02 Thread Paul E. McKenney
On Thu, Apr 02, 2020 at 12:19:54PM -0400, Qian Cai wrote: > > > > On Apr 2, 2020, at 11:54 AM, Paul E. McKenney wrote: > > > > I do run this combination quite frequently, but only as part of > > rcutorture, which might not be a representative workload. For one thing, > > it has a minimal

Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-02 Thread Qian Cai
> On Apr 2, 2020, at 11:54 AM, Paul E. McKenney wrote: > > I do run this combination quite frequently, but only as part of > rcutorture, which might not be a representative workload. For one thing, > it has a minimal userspace consisting only of a trivial init program. > I don't recall

Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-02 Thread Paul E. McKenney
On Thu, Apr 02, 2020 at 10:00:16AM -0400, Qian Cai wrote: > > > > On Apr 2, 2020, at 7:24 AM, Michael Ellerman wrote: > > > > Qian Cai writes: > >> From: Peter Zijlstra > >> > >> In the CPU-offline process, it calls mmdrop() after idle entry and the > >> subsequent call to

Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-02 Thread Qian Cai
> On Apr 2, 2020, at 7:24 AM, Michael Ellerman wrote: > > Qian Cai writes: >> From: Peter Zijlstra >> >> In the CPU-offline process, it calls mmdrop() after idle entry and the >> subsequent call to cpuhp_report_idle_dead(). Once execution passes the >> call to rcu_report_dead(), RCU is

Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-02 Thread Michael Ellerman
Qian Cai writes: > From: Peter Zijlstra > > In the CPU-offline process, it calls mmdrop() after idle entry and the > subsequent call to cpuhp_report_idle_dead(). Once execution passes the > call to rcu_report_dead(), RCU is ignoring the CPU, which results in > lockdep complaining when mmdrop()

[PATCH v2] sched/core: fix illegal RCU from offline CPUs

2020-04-01 Thread Qian Cai
From: Peter Zijlstra In the CPU-offline process, it calls mmdrop() after idle entry and the subsequent call to cpuhp_report_idle_dead(). Once execution passes the call to rcu_report_dead(), RCU is ignoring the CPU, which results in lockdep complaining when mmdrop() uses RCU from either memcg or