Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2008-01-03 Thread Timur Tabi
Scott Wood wrote: +static struct of_platform_driver ucc_uart_of_driver = { + .owner = THIS_MODULE, + .name = ucc_uart, Maybe better fsl,ucc_uart? fsl,qe-uart is defined by Documentation/powerpc/booting-without-of.txt. Wait, I'm confused. What does the

Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2008-01-03 Thread Scott Wood
Timur Tabi wrote: Scott Wood wrote: +static struct of_platform_driver ucc_uart_of_driver = { +.owner = THIS_MODULE, +.name = ucc_uart, Maybe better fsl,ucc_uart? fsl,qe-uart is defined by Documentation/powerpc/booting-without-of.txt. Wait, I'm confused. What does

Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2008-01-03 Thread Anton Vorontsov
On Thu, Jan 03, 2008 at 12:26:27PM -0600, Timur Tabi wrote: Scott Wood wrote: +static struct of_platform_driver ucc_uart_of_driver = { +.owner = THIS_MODULE, +.name = ucc_uart, Maybe better fsl,ucc_uart? fsl,qe-uart is defined by

Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2008-01-02 Thread Scott Wood
On Sat, Dec 29, 2007 at 04:10:54PM -0600, Timur Tabi wrote: Anton Vorontsov wrote: + [EMAIL PROTECTED] { + device_type = serial; + compatible = ucc_uart; + model = UCC; model isn't used, is it needed at all? I have no

Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2007-12-29 Thread Timur Tabi
Anton Vorontsov wrote: +[EMAIL PROTECTED] { +device_type = serial; +compatible = ucc_uart; +model = UCC; model isn't used, is it needed at all? I have no idea, but all the other UCC nodes have it, so I'm going to

Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2007-12-26 Thread Anton Vorontsov
On Fri, Dec 07, 2007 at 10:44:30AM -0600, Timur Tabi wrote: Add support for UART serial ports using a Freescale QUICC Engine (found on some MPC83xx and MPC85xx SOCs). Updated booting-without-of.txt to define new properties for a QE UART node, and a new node definition that describes uploaded

[PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

2007-12-07 Thread Timur Tabi
Add support for UART serial ports using a Freescale QUICC Engine (found on some MPC83xx and MPC85xx SOCs). Updated booting-without-of.txt to define new properties for a QE UART node, and a new node definition that describes uploaded QE firmware. Because of a silicon bug in some QE-enabled SOCs