Re: [PATCH v2 01/10] cxl: Drop commands if the PCI channel is not in normal state

> Hey Daniel, keeping in mind I can't exactly test it, and that I don't know the > ins and outs of CAPI, the code looks nice and it makes sence to me. > Thanks! > Some very minor points, > > Otherwise > > Acked-by: Cyril Bur > > > > > +static inline bool cxl_adapter_link_ok(struct cxl *cxl

Re: [PATCH v2 01/10] cxl: Drop commands if the PCI channel is not in normal state

On Tue, 28 Jul 2015 15:28:34 +1000 Daniel Axtens wrote: > If the PCI channel has gone down, don't attempt to poke the hardware. > > We need to guard every time cxl_whatever_(read|write) is called. This > is because a call to those functions will dereference an offset into an > mmio register, and

[PATCH v2 01/10] cxl: Drop commands if the PCI channel is not in normal state

If the PCI channel has gone down, don't attempt to poke the hardware. We need to guard every time cxl_whatever_(read|write) is called. This is because a call to those functions will dereference an offset into an mmio register, and the mmio mappings get invalidated in the EEH teardown. Check in th