Re: [PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > diff --git a/drivers/net/wan/fsl_qmc_hdlc.c

Re: [PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 11:31:32 +0200 Andrew Lunn wrote: > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > *netdev) > > +{ > > + return (struct qmc_hdlc *)dev_to_hdlc(netdev)->priv; > > priv is a void *, so you don't need the cast. > Right, I will change in the

Re: [PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-08-01 Thread Andrew Lunn
> +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device *netdev) > +{ > + return (struct qmc_hdlc *)dev_to_hdlc(netdev)->priv; priv is a void *, so you don't need the cast. Andrew

[PATCH v2 06/28] net: wan: Add support for QMC HDLC

2023-07-26 Thread Herve Codina
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data. Signed-off-by: Herve Codina --- drivers/net/wan/Kconfig| 12 + drivers/net/wan/Makefile | 1 + drivers/net/wan/fsl_qmc_hdlc.c | 422