Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Shengjiu Wang
On Tue, Jun 23, 2020 at 4:55 PM Markus Elfring wrote: > > > clk_prepare_enable and clk_disable_unprepare check the input > > clock parameter in the beginning of the function, > > These functions call further functions which perform null pointer checks. > > > >

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Markus Elfring
> clk_prepare_enable and clk_disable_unprepare check the input > clock parameter in the beginning of the function, These functions call further functions which perform null pointer checks. > if the parameter > is NULL, clk_prepare

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Shengjiu Wang
On Tue, Jun 23, 2020 at 3:38 PM Markus Elfring wrote: > > > In-Reply-To: > > I guess that it should be sufficient to specify such a field once > for the header information. seems it's caused by my "git format-patch" command, I will update it, hope it is better next time. > > > > Because clk_pre

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-23 Thread Markus Elfring
> In-Reply-To: I guess that it should be sufficient to specify such a field once for the header information. > Because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not internally, I find this change description unclear. > then we don't need to

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-22 Thread Nicolin Chen
On Tue, Jun 23, 2020 at 02:01:11PM +0800, Shengjiu Wang wrote: > Because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not internally, then > we don't need to check them before calling the function. > > Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS com

[PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

2020-06-22 Thread Shengjiu Wang
Because clk_prepare_enable and clk_disable_unprepare should check input clock parameter is NULL or not internally, then we don't need to check them before calling the function. Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_mqs.