Hi Rafael,
Thanks for the Review. Few inline replies below.
On 04/09/2019 03:31 PM, Rafael J. Wysocki wrote:
On Fri, Apr 5, 2019 at 11:17 AM Abhishek Goel
wrote:
Currently, the cpuidle governors (menu /ladder) determine what idle state
There are three governors in 5.1-rc.
an idling CPU
On Fri, Apr 5, 2019 at 11:17 AM Abhishek Goel
wrote:
>
> Currently, the cpuidle governors (menu /ladder) determine what idle state
There are three governors in 5.1-rc.
> an idling CPU should enter into based on heuristics that depend on the
> idle history on that CPU. Given that no predictive
On 04/09/2019 03:00 PM, Rafael J. Wysocki wrote:
On Tue, Apr 9, 2019 at 11:29 AM Abhishek wrote:
Hi Daniel,
Thanks for such a descriptive review. I will include all the suggestions
made in my next iteration.
Please give me some time to send comments before that.
Sure, I will wait for your
Hi Daniel,
On 04/08/2019 07:55 PM, Daniel Axtens wrote:
Hi,
Sorry, just realised another thing I wanted to ask:
@@ -442,6 +442,26 @@ static int menu_select(struct cpuidle_driver *drv, struct
cpuidle_device *dev,
}
}
+#ifdef CPUIDLE_FLAG_AUTO_PROMOTION
Why is this
On Tue, Apr 9, 2019 at 11:29 AM Abhishek wrote:
>
> Hi Daniel,
>
> Thanks for such a descriptive review. I will include all the suggestions
> made in my next iteration.
Please give me some time to send comments before that.
Hi Daniel,
Thanks for such a descriptive review. I will include all the suggestions
made in my next iteration.
--Abhishek
On 04/08/2019 07:42 PM, Daniel Axtens wrote:
Hi Abhishek,
Currently, the cpuidle governors (menu /ladder) determine what idle state
an idling CPU should enter into
Hi,
Sorry, just realised another thing I wanted to ask:
> @@ -442,6 +442,26 @@ static int menu_select(struct cpuidle_driver *drv,
> struct cpuidle_device *dev,
> }
> }
>
>
> +#ifdef CPUIDLE_FLAG_AUTO_PROMOTION
Why is this based on CPUIDLE_FLAG_ rather than CONFIG_CPU_IDLE_?
Hi Abhishek,
> Currently, the cpuidle governors (menu /ladder) determine what idle state
> an idling CPU should enter into based on heuristics that depend on the
> idle history on that CPU. Given that no predictive heuristic is perfect,
> there are cases where the governor predicts a shallow idle
Currently, the cpuidle governors (menu /ladder) determine what idle state
an idling CPU should enter into based on heuristics that depend on the
idle history on that CPU. Given that no predictive heuristic is perfect,
there are cases where the governor predicts a shallow idle state, hoping
that
