RE: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-09 Thread David Laight
From: David T-G > Sent: 09 February 2022 13:42 > > ...and then Wols Lists said... > % > % On 08/02/2022 15:21, Paul Menzel wrote: > ... > % > % As commented elsewhere, for the sake of us ENGLISH speakers, > % *PLEASE* make that $(hash). A pound sign is £. > > Or, even better, $(octothorpe) since

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-09 Thread David T-G
Paul, et al -- ...and then Wols Lists said... % % On 08/02/2022 15:21, Paul Menzel wrote: ... % % As commented elsewhere, for the sake of us ENGLISH speakers, % *PLEASE* make that $(hash). A pound sign is £. Or, even better, $(octothorpe) since that's merely a symbol rather than a food product

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Wols Lists
On 08/02/2022 15:21, Paul Menzel wrote: So, do the same as commit 9564a8cf422d ("Kbuild: fix # escaping in .cmd files for future Make") and commit 929bef467771 ("bpf: Use $(pound) instead of \# in Makefiles") and define and use a `$(pound)` variable. As commented elsewhere, for the sake of us

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Song Liu
On Tue, Feb 8, 2022 at 7:22 AM Paul Menzel wrote: > > Buidling `raid6test` on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows the > errors below: > > $ cd lib/raid6/test/ > $ make > :1:1: error: stray ‘\’ in program > :1:2: error: stray ‘#’ in program > :1:11: error: expected

[PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Paul Menzel
Buidling `raid6test` on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows the errors below: $ cd lib/raid6/test/ $ make :1:1: error: stray ‘\’ in program :1:2: error: stray ‘#’ in program :1:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘<’ token cp -f