Re: [PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return

2023-02-14 Thread Josh Poimboeuf
On Tue, Feb 14, 2023 at 08:57:39AM +0100, Philippe Mathieu-Daudé wrote: > On 14/2/23 08:05, Josh Poimboeuf wrote: > > play_dead() doesn't return. Make that more explicit with a BUG(). > > > > BUG() is preferable to unreachable() because BUG() is a more explicit > > failure mode and avoids

Re: [PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be

[PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf ---