Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-02 Thread Jens Axboe
On Tue, Oct 02 2007, Benjamin Herrenschmidt wrote: On Mon, 2007-10-01 at 13:59 +0200, Jens Axboe wrote: On Sun, Sep 30 2007, Grant Likely wrote: On 9/30/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: + if ((rc =

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-02 Thread Grant Likely
On 10/2/07, Jens Axboe [EMAIL PROTECTED] wrote: On Tue, Oct 02 2007, Benjamin Herrenschmidt wrote: On Mon, 2007-10-01 at 13:59 +0200, Jens Axboe wrote: Just send a fixup patch for that, I'll add your series to the block tree for 2.6.24. It's actually better off living in the powerpc

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 13:59 +0200, Jens Axboe wrote: On Sun, Sep 30 2007, Grant Likely wrote: On 9/30/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: + if ((rc = platform_driver_register(ace_platform_driver)) != 0) +

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-09-30 Thread Christoph Hellwig
On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: + if ((rc = platform_driver_register(ace_platform_driver)) != 0) + goto err_plat; rc = platform_driver_register(ace_platform_driver); if (rc) goto err_plat; please. + err_plat:

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-09-30 Thread Grant Likely
On 9/30/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: + if ((rc = platform_driver_register(ace_platform_driver)) != 0) + goto err_plat; rc = platform_driver_register(ace_platform_driver); if (rc)