Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-28 Thread Benjamin Herrenschmidt
On Thu, 2017-12-28 at 17:22 -0600, Bjorn Helgaas wrote: > Both paths end up calling the pci_error_handlers.error_detected() > hook. > > Drivers are not supposed to care what arch they're running on. If the > driver supplies an .error_detected() entry point, it's up to the PCI > core and powerpc c

Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-28 Thread Bjorn Helgaas
On Wed, Dec 20, 2017 at 09:04:27PM -0600, Juan Alvarez wrote: > On 12/19/17 12:27 AM, Benjamin Herrenschmidt wrote: > > > On Mon, 2017-12-18 at 22:50 -0600, Bjorn Helgaas wrote: > >> [+cc Keith, Gabriele, Dongdong] > >> > >> On Mon, Dec 18, 2017 at 04:38:03PM -0600, Bryant G. Ly wrote: > >>> Devic

Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-20 Thread Juan Alvarez
On 12/19/17 12:27 AM, Benjamin Herrenschmidt wrote: > On Mon, 2017-12-18 at 22:50 -0600, Bjorn Helgaas wrote: >> [+cc Keith, Gabriele, Dongdong] >> >> On Mon, Dec 18, 2017 at 04:38:03PM -0600, Bryant G. Ly wrote: >>> Devices can go offline when EEH is reported. This patch adds >>> a change to the

Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-20 Thread Juan Alvarez
On 12/18/17 10:59 PM, Russell Currey wrote: > On Mon, 2017-12-18 at 22:50 -0600, Bjorn Helgaas wrote: >> [+cc Keith, Gabriele, Dongdong] >> >> On Mon, Dec 18, 2017 at 04:38:03PM -0600, Bryant G. Ly wrote: >>> Devices can go offline when EEH is reported. This patch adds >>> a change to the kernel o

Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-18 Thread Benjamin Herrenschmidt
On Mon, 2017-12-18 at 22:50 -0600, Bjorn Helgaas wrote: > [+cc Keith, Gabriele, Dongdong] > > On Mon, Dec 18, 2017 at 04:38:03PM -0600, Bryant G. Ly wrote: > > Devices can go offline when EEH is reported. This patch adds > > a change to the kernel object and lets udev know of error. > > When devic

Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-18 Thread Russell Currey
On Mon, 2017-12-18 at 22:50 -0600, Bjorn Helgaas wrote: > [+cc Keith, Gabriele, Dongdong] > > On Mon, Dec 18, 2017 at 04:38:03PM -0600, Bryant G. Ly wrote: > > Devices can go offline when EEH is reported. This patch adds > > a change to the kernel object and lets udev know of error. > > When devic

Re: [PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-18 Thread Bjorn Helgaas
[+cc Keith, Gabriele, Dongdong] On Mon, Dec 18, 2017 at 04:38:03PM -0600, Bryant G. Ly wrote: > Devices can go offline when EEH is reported. This patch adds > a change to the kernel object and lets udev know of error. > When device resumes a change is also set reporting device as > online. Therefo

[PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-18 Thread Bryant G. Ly
Devices can go offline when EEH is reported. This patch adds a change to the kernel object and lets udev know of error. When device resumes a change is also set reporting device as online. Therefore, EEH events are better propagated to user space for devices in powerpc arch. Signed-off-by: Bryant